-
Notifications
You must be signed in to change notification settings - Fork 97
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream #871
7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream #871
Conversation
👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into |
❗ This change is not yet ready to be integrated. |
This backport pull request has now been updated with issue from the original commit. |
At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the |
/approval request This is a clean backport of a fix that has been in JDK since March 2024. It addresses an issue that has been causing real problems for us. The original change has a CSR. I understand I am meant to open a duplicate CSR for this backport, but it seems I must first create the backport ticket? I apologize if I'm taking any steps out of turn. |
@earthling-amzn |
The CSR for this is only approved for 23+ at this time. |
Yes, if you want this to be backported, you should create a backport item in JBS and from that open a CSR. The CSR needs to be approved (and the backport be reviewed) before re-requesting maintainer approval. |
@earthling-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
@earthling-amzn This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
Clean backport.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/871/head:pull/871
$ git checkout pull/871
Update a local copy of the PR:
$ git checkout pull/871
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/871/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 871
View PR using the GUI difftool:
$ git pr show -t 871
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/871.diff
Webrev
Link to Webrev Comment