Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream #871

Conversation

earthling-amzn
Copy link

@earthling-amzn earthling-amzn commented Jul 26, 2024

Clean backport.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change requires a CSR request matching fixVersion 21.0.6 to be approved (needs to be created)
  • JDK-7036144 needs maintainer approval

Issue

  • JDK-7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/871/head:pull/871
$ git checkout pull/871

Update a local copy of the PR:
$ git checkout pull/871
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/871/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 871

View PR using the GUI difftool:
$ git pr show -t 871

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/871.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2024

👋 Welcome back wkemper! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport d3f3011d56267360d65841da3550eca79cf1575b 7036144: GZIPInputStream readTrailer uses faulty available() test for end-of-stream Jul 26, 2024
@openjdk
Copy link

openjdk bot commented Jul 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

At least one of the issues associated with this backport has a resolved CSR for a different version. As this means that this backport may also need a CSR, the csr label is being added to this pull request to signal this potential requirement. The command /csr unneeded can be used to remove the label in case a CSR is not needed.

@openjdk openjdk bot added csr Pull request needs approved CSR before integration rfr Pull request is ready for review labels Jul 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2024

Webrevs

@earthling-amzn
Copy link
Author

/approval request This is a clean backport of a fix that has been in JDK since March 2024. It addresses an issue that has been causing real problems for us. The original change has a CSR. I understand I am meant to open a duplicate CSR for this backport, but it seems I must first create the backport ticket? I apologize if I'm taking any steps out of turn.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@earthling-amzn
7036144: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Jul 26, 2024
@AlanBateman
Copy link

The CSR for this is only approved for 23+ at this time.

@RealCLanger
Copy link
Contributor

/approval request This is a clean backport of a fix that has been in JDK since March 2024. It addresses an issue that has been causing real problems for us. The original change has a CSR. I understand I am meant to open a duplicate CSR for this backport, but it seems I must first create the backport ticket? I apologize if I'm taking any steps out of turn.

Yes, if you want this to be backported, you should create a backport item in JBS and from that open a CSR. The CSR needs to be approved (and the backport be reviewed) before re-requesting maintainer approval.

@openjdk openjdk bot removed the approval label Jul 29, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 26, 2024

@earthling-amzn This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 23, 2024

@earthling-amzn This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean csr Pull request needs approved CSR before integration rfr Pull request is ready for review
Development

Successfully merging this pull request may close these issues.

3 participants