Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]' #883

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Jul 31, 2024

Backport of 8332699; COPYRIGHT year


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8332699 needs maintainer approval

Issue

  • JDK-8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]' (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/883/head:pull/883
$ git checkout pull/883

Update a local copy of the PR:
$ git checkout pull/883
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/883/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 883

View PR using the GUI difftool:
$ git pr show -t 883

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/883.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 31, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • c2daaa6: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • a757e62: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero
  • c3b424e: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
  • 7239584: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test
  • 43cb913: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
  • e478a23: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout
  • 462065b: 8335904: Fix invalid comment in ShenandoahLock
  • c9d8681: 8308286: Fix clang warnings in linux code
  • 30801fb: 8317696: Fix compilation with clang-16

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport abbf45b57edf2f5bf9a3f2fa408f35a43ebe9bb9 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]' Jul 31, 2024
@openjdk
Copy link

openjdk bot commented Jul 31, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 31, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 31, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 31, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 1, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Aug 2, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

Going to push as commit 0fdb206.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 6bc382f: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null
  • c2daaa6: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • a757e62: 8333277: ubsan: mlib_ImageScanPoly.c:292:43: runtime error: division by zero
  • c3b424e: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
  • 7239584: 8291809: Convert compiler/c2/cr7200264/TestSSE2IntVect.java to IR verification test
  • 43cb913: 8325037: x86: enable and fix hotspot/jtreg/compiler/vectorization/TestRoundVectFloat.java
  • e478a23: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout
  • 462065b: 8335904: Fix invalid comment in ShenandoahLock
  • c9d8681: 8308286: Fix clang warnings in linux code
  • 30801fb: 8317696: Fix compilation with clang-16

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2024
@openjdk openjdk bot closed this Aug 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2024
@openjdk
Copy link

openjdk bot commented Aug 2, 2024

@MBaesken Pushed as commit 0fdb206.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant