Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer #892

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 1, 2024

Backport of 8331731, relocInfo.cpp assert had to be added manually


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8331731 needs maintainer approval

Issue

  • JDK-8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/892/head:pull/892
$ git checkout pull/892

Update a local copy of the PR:
$ git checkout pull/892
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/892/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 892

View PR using the GUI difftool:
$ git pr show -t 892

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/892.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 1, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 1, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer

Reviewed-by: rschmelter

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • ee21571: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs
  • 30294f4: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510
  • 3511d72: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 81d1c97: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
  • ce67ab0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • 7c2666d: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • 9cb36b2: 8324580: SIGFPE on THP initialization on kernels < 4.10
  • 0fdb206: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
  • 6bc382f: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 664c993c41753843293388a6ff1481a94a5b4c22 8331731: ubsan: relocInfo.cpp:155:30: runtime error: applying non-zero offset to null pointer Aug 1, 2024
@openjdk
Copy link

openjdk bot commented Aug 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Aug 1, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 1, 2024

Webrevs

Copy link
Contributor

@schmelter-sap schmelter-sap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 2, 2024
@MBaesken
Copy link
Member Author

MBaesken commented Aug 2, 2024

Thanks for the review !

/integrate

@openjdk
Copy link

openjdk bot commented Aug 2, 2024

Going to push as commit b79e185.
Since your change was applied there have been 9 commits pushed to the master branch:

  • ee21571: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs
  • 30294f4: 8331854: ubsan: copy.hpp:218:10: runtime error: addition of unsigned offset to 0x7fc2b4024518 overflowed to 0x7fc2b4024510
  • 3511d72: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 81d1c97: 8324808: Manual printer tests have no Pass/Fail buttons, instructions close set 3
  • ce67ab0: 8317112: Add screenshot for Frame/DefaultSizeTest.java
  • 7c2666d: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • 9cb36b2: 8324580: SIGFPE on THP initialization on kernels < 4.10
  • 0fdb206: 8332699: ubsan: jfrEventSetting.inline.hpp:31:43: runtime error: index 163 out of bounds for type 'jfrNativeEventSetting [162]'
  • 6bc382f: 8333178: ubsan: jvmti_tools.cpp:149:16: runtime error: null pointer passed as argument 2, which is declared to never be null

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 2, 2024
@openjdk openjdk bot closed this Aug 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2024
@openjdk
Copy link

openjdk bot commented Aug 2, 2024

@MBaesken Pushed as commit b79e185.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants