Skip to content

Conversation

@jia-wei-tang
Copy link

@jia-wei-tang jia-wei-tang commented Aug 9, 2024

I will backport JDK-8337331 after this to fix the deadlock / jvm crash problem.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8330146 needs maintainer approval

Issue

  • JDK-8330146: assert(!_thread->is_in_any_VTMS_transition()) failed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/907/head:pull/907
$ git checkout pull/907

Update a local copy of the PR:
$ git checkout pull/907
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/907/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 907

View PR using the GUI difftool:
$ git pr show -t 907

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/907.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 9, 2024

👋 Welcome back jwtang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@jia-wei-tang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8330146: assert(!_thread->is_in_any_VTMS_transition()) failed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • e4d27d0: 8334618: ubsan: support setting additional ubsan check options
  • 953846d: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c4ff58b9bcfd08eae0623a648a837e08f25b3f9b 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Aug 9, 2024
@openjdk
Copy link

openjdk bot commented Aug 9, 2024

⚠️ @jia-wei-tang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 9, 2024
@jia-wei-tang
Copy link
Author

/approval

@mlbridge
Copy link

mlbridge bot commented Aug 9, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@jia-wei-tang usage: /approval [<id>] (request|cancel) [<text>]

@jia-wei-tang
Copy link
Author

/approval request fix bugs for jdk21. It's a clean backport. After this, I will backport JDK-8337331 to fix the problem completely.

@openjdk
Copy link

openjdk bot commented Aug 9, 2024

@jia-wei-tang
8330146: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 9, 2024
@jia-wei-tang
Copy link
Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 12, 2024
@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@jia-wei-tang
Your change (at version 126d8cb) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

All right. You need to pick up JDK-8337331 immediately after this.

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

Going to push as commit 27b1e1a.
Since your change was applied there have been 3 commits pushed to the master branch:

  • 27abeb8: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • e4d27d0: 8334618: ubsan: support setting additional ubsan check options
  • 953846d: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 12, 2024
@openjdk openjdk bot closed this Aug 12, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 12, 2024
@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@shipilev @jia-wei-tang Pushed as commit 27b1e1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants