-
Notifications
You must be signed in to change notification settings - Fork 147
8324641: [IR Framework] Add Setup method to provide custom arguments and set fields #911
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 10 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
|
This backport pull request has now been updated with issue from the original commit. |
|
@chhagedorn, FYI, I am bringing this to JDK 21 to make IR tests cleaner. |
|
|
|
/approval request Improves IR Framework, allows backporting IR Tests without modifications. Applies almost cleanly, some hunks cannot be applied due to missing files. All IR tests and IR Framework tests continue to pass. Risk is low: affects a limited number of tests. |
|
/integrate |
|
Going to push as commit d4a6e72.
Your commit was automatically rebased without conflicts. |
Improves IR Framework, allows backporting IR Tests without modifications. Applies nearly cleanly, except the hunk in
compiler/c2/irTests/TestTestRemovalPeephole.java, since this file does not exist in JDK 21.Additional testing:
@Argumentsyields no unfixed cases in test suitetestlibrary_tests/ir_framework compiler/c2/irTeststestlibrary_tests/ir_framework compiler/c2/irTeststestlibrary_tests/ir_framework compiler/c2/irTestsProgress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/911/head:pull/911$ git checkout pull/911Update a local copy of the PR:
$ git checkout pull/911$ git pull https://git.openjdk.org/jdk21u-dev.git pull/911/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 911View PR using the GUI difftool:
$ git pr show -t 911Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/911.diff
Webrev
Link to Webrev Comment