Skip to content

Conversation

@shipilev
Copy link
Member

@shipilev shipilev commented Aug 12, 2024

Improves IR Framework, allows backporting IR Tests without modifications. Applies nearly cleanly, except the hunk in compiler/c2/irTests/TestTestRemovalPeephole.java, since this file does not exist in JDK 21.

Additional testing:

  • Grep @Arguments yields no unfixed cases in test suite
  • MacOS AArch64 server fastdebug, testlibrary_tests/ir_framework compiler/c2/irTests
  • Linux AArch64 server release, testlibrary_tests/ir_framework compiler/c2/irTests
  • Linux AArch64 server fastdebug, testlibrary_tests/ir_framework compiler/c2/irTests

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8324641 needs maintainer approval

Issue

  • JDK-8324641: [IR Framework] Add Setup method to provide custom arguments and set fields (Sub-task - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/911/head:pull/911
$ git checkout pull/911

Update a local copy of the PR:
$ git checkout pull/911
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/911/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 911

View PR using the GUI difftool:
$ git pr show -t 911

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/911.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8324641: [IR Framework] Add Setup method to provide custom arguments and set fields

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 75c82f6: 8336343: Add more known sysroot library locations for ALSA
  • 123614b: 8336928: GHA: Bundle artifacts removal broken
  • 9ac591a: 8336342: Fix known X11 library locations in sysroot
  • bafcddd: 8337283: configure.log is truncated when build dir is on different filesystem
  • eb103b0: 8327501: Common ForkJoinPool prevents class unloading in some cases
  • 27b1e1a: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed
  • 27abeb8: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • e4d27d0: 8334618: ubsan: support setting additional ubsan check options
  • 953846d: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
  • fd4ce63: 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 8d9ad97c293b090fbcedbfdb046f1b5d97b02f87 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields Aug 12, 2024
@openjdk
Copy link

openjdk bot commented Aug 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base rfr Pull request is ready for review labels Aug 12, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2024

Webrevs

@shipilev
Copy link
Member Author

@chhagedorn, FYI, I am bringing this to JDK 21 to make IR tests cleaner.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@shipilev
Copy link
Member Author

/approval request Improves IR Framework, allows backporting IR Tests without modifications. Applies almost cleanly, some hunks cannot be applied due to missing files. All IR tests and IR Framework tests continue to pass. Risk is low: affects a limited number of tests.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@shipilev
8324641: The approval request has been created successfully.

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Aug 12, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

Going to push as commit d4a6e72.
Since your change was applied there have been 10 commits pushed to the master branch:

  • 75c82f6: 8336343: Add more known sysroot library locations for ALSA
  • 123614b: 8336928: GHA: Bundle artifacts removal broken
  • 9ac591a: 8336342: Fix known X11 library locations in sysroot
  • bafcddd: 8337283: configure.log is truncated when build dir is on different filesystem
  • eb103b0: 8327501: Common ForkJoinPool prevents class unloading in some cases
  • 27b1e1a: 8330146: assert(!_thread->is_in_any_VTMS_transition()) failed
  • 27abeb8: 8328642: Convert applet test MouseDraggedOutCauseScrollingTest.html to main
  • e4d27d0: 8334618: ubsan: support setting additional ubsan check options
  • 953846d: 8333639: ubsan: cppVtables.cpp:81:55: runtime error: index 14 out of bounds for type 'long int [1]'
  • fd4ce63: 8322971: KEM.getInstance() should check if a 3rd-party security provider is signed

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 13, 2024
@openjdk openjdk bot closed this Aug 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 13, 2024
@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@shipilev Pushed as commit d4a6e72.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants