Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8303920: Avoid calling out to python in DataDescriptorSignatureMissing test #913

Closed
wants to merge 2 commits into from

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented Aug 12, 2024

Backport of improvements to DataDescriptorSignatureMissing test. Unclean for this trivial issue fix in 22 that adds a bug-id for @ignore. Otherwise, it's a clean backport.

Passes tier1 tests and the test itself on Linux x64


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8303920 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8303920: Avoid calling out to python in DataDescriptorSignatureMissing test (Enhancement - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/913/head:pull/913
$ git checkout pull/913

Update a local copy of the PR:
$ git checkout pull/913
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/913/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 913

View PR using the GUI difftool:
$ git pr show -t 913

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/913.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8303920: Avoid calling out to python in DataDescriptorSignatureMissing test

Reviewed-by: shade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

  • edd6437: 8319817: Charset constructor should make defensive copy of aliases
  • 590715f: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable
  • 108c2e4: 8334166: Enable binary check
  • 5acb022: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
  • 6196ed1: 8332113: Update nsk.share.Log to be always verbose
  • 785ae1f: 8315965: Open source various AWT applet tests
  • 7e7b0f3: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
  • 8150179: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
  • d4a6e72: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields
  • 75c82f6: 8336343: Add more known sysroot library locations for ALSA
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/eb103b0e1abeeee19779cafc763d3d159030fb48...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport 07eaea8c25bae6ed852685f082f8b50c5b20c1a9 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test Aug 12, 2024
@openjdk
Copy link

openjdk bot commented Aug 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 12, 2024
@cost0much cost0much marked this pull request as ready for review August 12, 2024 23:38
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 12, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 12, 2024

Webrevs

Copy link
Member

@shipilev shipilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, except for:

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@cost0much
Copy link
Contributor Author

/approval request Improves the test DataDescriptorSignatureMissing added by JDK-8303920 in JDK22. Does not apply cleanly, but the discrepancy is trivial. Affected test passes. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@cost0much
8303920: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 13, 2024
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@cost0much
Your change (at version 0d4c3d2) is now ready to be sponsored by a Committer.

@shipilev
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

Going to push as commit 79349b8.
Since your change was applied there have been 13 commits pushed to the master branch:

  • edd6437: 8319817: Charset constructor should make defensive copy of aliases
  • 590715f: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable
  • 108c2e4: 8334166: Enable binary check
  • 5acb022: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
  • 6196ed1: 8332113: Update nsk.share.Log to be always verbose
  • 785ae1f: 8315965: Open source various AWT applet tests
  • 7e7b0f3: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
  • 8150179: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
  • d4a6e72: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields
  • 75c82f6: 8336343: Add more known sysroot library locations for ALSA
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/eb103b0e1abeeee19779cafc763d3d159030fb48...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 14, 2024
@openjdk openjdk bot closed this Aug 14, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 14, 2024
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@shipilev @cost0much Pushed as commit 79349b8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cost0much cost0much deleted the JDK-8303920 branch August 14, 2024 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants