-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8303920: Avoid calling out to python in DataDescriptorSignatureMissing test #913
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@shipilev) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, except for:
|
/approval request Improves the test DataDescriptorSignatureMissing added by JDK-8303920 in JDK22. Does not apply cleanly, but the discrepancy is trivial. Affected test passes. Risk is low: the change is test code only. |
@cost0much |
/integrate |
@cost0much |
/sponsor |
Going to push as commit 79349b8.
Your commit was automatically rebased without conflicts. |
@shipilev @cost0much Pushed as commit 79349b8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of improvements to DataDescriptorSignatureMissing test. Unclean for this trivial issue fix in 22 that adds a bug-id for
@ignore
. Otherwise, it's a clean backport.Passes tier1 tests and the test itself on Linux x64
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/913/head:pull/913
$ git checkout pull/913
Update a local copy of the PR:
$ git checkout pull/913
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/913/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 913
View PR using the GUI difftool:
$ git pr show -t 913
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/913.diff
Webrev
Link to Webrev Comment