-
Notifications
You must be signed in to change notification settings - Fork 129
8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 #914
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 4 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/issue add JDK-8319960 |
@cost0much |
|
/approval 8319970 request Improves coverage for aarch64 platforms for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod. Does not apply cleanly due to RISC-V intrinsics support only in later versions. Affected tests pass. Risk is low: the change is test code only. /approval 8319960 request Fixes compiler/intrinsics/Test(Long|Integer)UnsignedDivMod failing when enabled for non-x64 platforms. Applies cleanly and affected tests pass. Risk is low: the change is test code only. |
@cost0much |
@cost0much |
/integrate |
@cost0much |
/sponsor |
Going to push as commit fb72870.
Your commit was automatically rebased without conflicts. |
@benty-amzn @cost0much Pushed as commit fb72870. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport of JDK-8319970 that enables tests for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64. Not clean because RISC-V intrinsics for divideUnsigned and remainderUnsigned were added in JDK22; aarch64 intrinsics for divideUnsigned and remainderUnsigned confirmed to be released in JDK20.
This includes backport of JDK-8319960 because the
UDivModI
orUDivModL
nodes are supplied from x86_64.ad, thus these node checks are intended for x64 platforms. Although originally intended to fix the test failing for RISC-V intrinsics, without this exclusion the test will also fail for aarch64 platforms, thus it is included as part of the backport.Passes affected tests on Linux aarch64 and Mac aarch64.
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/914/head:pull/914
$ git checkout pull/914
Update a local copy of the PR:
$ git checkout pull/914
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/914/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 914
View PR using the GUI difftool:
$ git pr show -t 914
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/914.diff
Webrev
Link to Webrev Comment