Skip to content

8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 #914

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented Aug 12, 2024

Backport of JDK-8319970 that enables tests for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64. Not clean because RISC-V intrinsics for divideUnsigned and remainderUnsigned were added in JDK22; aarch64 intrinsics for divideUnsigned and remainderUnsigned confirmed to be released in JDK20.

This includes backport of JDK-8319960 because the UDivModI or UDivModL nodes are supplied from x86_64.ad, thus these node checks are intended for x64 platforms. Although originally intended to fix the test failing for RISC-V intrinsics, without this exclusion the test will also fail for aarch64 platforms, thus it is included as part of the backport.

Passes affected tests on Linux aarch64 and Mac aarch64.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8319960 needs maintainer approval
  • JDK-8319970 needs maintainer approval

Issues

  • JDK-8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 (Enhancement - P4 - Approved)
  • JDK-8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes" (Bug - P4 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/914/head:pull/914
$ git checkout pull/914

Update a local copy of the PR:
$ git checkout pull/914
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/914/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 914

View PR using the GUI difftool:
$ git pr show -t 914

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/914.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 12, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 12, 2024

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64
8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes"

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • e939761: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • eb80936: 8316895: SeenThread::print_action_queue called on a null pointer
  • b0da5c7: 8338110: Exclude Fingerprinter::do_type from ubsan checks
  • 669c2b4: 8339080: Bump update version for OpenJDK: jdk-21.0.6

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c80e691adf6f9ac1a41b2329ce366710e604e34e 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64 Aug 12, 2024
@openjdk
Copy link

openjdk bot commented Aug 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Aug 12, 2024
@cost0much
Copy link
Contributor Author

/issue add JDK-8319960

@openjdk
Copy link

openjdk bot commented Aug 27, 2024

@cost0much
Adding additional issue to issue list: 8319960: RISC-V: compiler/intrinsics/TestInteger/LongUnsignedDivMod.java failed with "counts: Graph contains wrong number of nodes".

@cost0much cost0much marked this pull request as ready for review August 27, 2024 20:40
@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 27, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 27, 2024

Webrevs

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@cost0much
Copy link
Contributor Author

/approval 8319970 request Improves coverage for aarch64 platforms for compiler/intrinsics/Test(Long|Integer)UnsignedDivMod. Does not apply cleanly due to RISC-V intrinsics support only in later versions. Affected tests pass. Risk is low: the change is test code only.

/approval 8319960 request Fixes compiler/intrinsics/Test(Long|Integer)UnsignedDivMod failing when enabled for non-x64 platforms. Applies cleanly and affected tests pass. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@cost0much
8319970: The approval request has been created successfully.

@openjdk
Copy link

openjdk bot commented Aug 28, 2024

@cost0much
8319960: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 28, 2024
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 29, 2024
@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@cost0much
Your change (at version 95c8f0a) is now ready to be sponsored by a Committer.

@benty-amzn
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

Going to push as commit fb72870.
Since your change was applied there have been 4 commits pushed to the master branch:

  • e939761: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • eb80936: 8316895: SeenThread::print_action_queue called on a null pointer
  • b0da5c7: 8338110: Exclude Fingerprinter::do_type from ubsan checks
  • 669c2b4: 8339080: Bump update version for OpenJDK: jdk-21.0.6

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 29, 2024
@openjdk openjdk bot closed this Aug 29, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Aug 29, 2024
@openjdk openjdk bot removed rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 29, 2024
@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@benty-amzn @cost0much Pushed as commit fb72870.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@cost0much cost0much deleted the JDK-8319970 branch August 29, 2024 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants