8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java

[sendaoYan]

Hi all,

This pull request contains a backport of commit f3bb3e21 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 26 Apr 2024 and was reviewed by Markus Grönlund.

This the prefixed backport of JDK-8323196.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• JDK-8331153 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/915/head:pull/915
$ git checkout pull/915

Update a local copy of the PR:
$ git checkout pull/915
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/915/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 915

View PR using the GUI difftool:
$ git pr show -t 915

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/915.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331153: JFR: Improve logging of jdk/jfr/api/consumer/filestream/TestOrdered.java

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 13 new commits pushed to the master branch:

• edd6437: 8319817: Charset constructor should make defensive copy of aliases
• 590715f: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable
• 108c2e4: 8334166: Enable binary check
• 5acb022: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
• 6196ed1: 8332113: Update nsk.share.Log to be always verbose
• 785ae1f: 8315965: Open source various AWT applet tests
• 7e7b0f3: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8150179: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
• d4a6e72: 8324641: [IR Framework] Add Setup method to provide custom arguments and set fields
• 75c82f6: 8336343: Add more known sysroot library locations for ALSA
• ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/eb103b0e1abeeee19779cafc763d3d159030fb48...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[sendaoYan]

/approval request Clean backport, to improves logging of a test to be able to debug failures more easily, no risk.

[openjdk]

@sendaoYan
8331153: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (3edfdc0a)

[jerboaa]

@sendaoYan Please provide some rationale why this debugging in a test is needed. Do you actually see test failures? Why are you backporting this?

[sendaoYan]

@sendaoYan Please provide some rationale why this debugging in a test is needed. Do you actually see test failures? Why are you backporting this?

Hi, we have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196, and this PR is the prefixed backport of JDK-8323196.

[jerboaa]

@sendaoYan Please provide some rationale why this debugging in a test is needed. Do you actually see test failures? Why are you backporting this?

Hi, we have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196, and this PR is the prefixed backport of JDK-8323196.

OK. Next time, please mention this in the fix request comment from the get go. It's useful info when looking for approval. Now, please re-issue the /approval command with the updated comment and I'll approve.

[sendaoYan]

/approval cancel

[openjdk]

@sendaoYan
8331153: The approval request has been cancelled successfully.

[sendaoYan]

/approval request Clean backport, to improves logging of a test to be able to debug failures more easily. We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196, and this PR is the prefixed backport of JDK-8323196. Test fix only, no risk.

[openjdk]

@sendaoYan
8331153: The approval request has been created successfully.

[jerboaa]

/approve yes

[openjdk]

@jerboaa
8331153: The approval request has been approved.

[sendaoYan]

/approve yes

Thanks for the approval.

/integrate

[openjdk]

@sendaoYan
Your change (at version 3edfdc0) is now ready to be sponsored by a Committer.

[TheRealMDoerr]

/sponsor

[openjdk]

Going to push as commit d85b7c1.
Since your change was applied there have been 15 commits pushed to the master branch:

• a3cd6d6: 8321206: Make Locale related system properties StaticProperty
• 79349b8: 8303920: Avoid calling out to python in DataDescriptorSignatureMissing test
• edd6437: 8319817: Charset constructor should make defensive copy of aliases
• 590715f: 8073061: (fs) Files.copy(foo, bar, REPLACE_EXISTING) deletes bar even if foo is not readable
• 108c2e4: 8334166: Enable binary check
• 5acb022: 6355567: AdobeMarkerSegment causes failure to read valid JPEG
• 6196ed1: 8332113: Update nsk.share.Log to be always verbose
• 785ae1f: 8315965: Open source various AWT applet tests
• 7e7b0f3: 8312049: runtime/logging/ClassLoadUnloadTest can be improved
• 8150179: 8242564: javadoc crashes:: class cast exception com.sun.tools.javac.code.Symtab$6
• ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/eb103b0e1abeeee19779cafc763d3d159030fb48...master

Your commit was automatically rebased without conflicts.

[openjdk]

@TheRealMDoerr @sendaoYan Pushed as commit d85b7c1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.