Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak #918

Closed
wants to merge 1 commit into from

Conversation

cost0much
Copy link
Contributor

@cost0much cost0much commented Aug 13, 2024

Clean backport. Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes tier1 tests on linux x64 and the test itself.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316193 needs maintainer approval

Issue

  • JDK-8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/918/head:pull/918
$ git checkout pull/918

Update a local copy of the PR:
$ git checkout pull/918
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/918/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 918

View PR using the GUI difftool:
$ git pr show -t 918

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/918.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 13, 2024

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 13, 2024

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

  • b8038ea: 8335743: jhsdb jstack cannot print some information on the waiting thread
  • e79f9b4: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
  • 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
  • dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
  • fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
  • d5b8ea8: 8330981: ZGC: Should not dedup strings in the finalizer graph
  • 38eeb50: 8335007: Inline OopMapCache table
  • affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
  • 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
  • cd5ac19: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • ... and 17 more: https://git.openjdk.org/jdk21u-dev/compare/d4a6e72a22cf8cee91dc9553454dd62fe0547b85...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f6be922952642f40dcf0d27b7896c9a6acdd6378 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak Aug 13, 2024
@openjdk
Copy link

openjdk bot commented Aug 13, 2024

This backport pull request has now been updated with issue from the original commit.

@cost0much cost0much marked this pull request as ready for review August 14, 2024 16:13
@openjdk
Copy link

openjdk bot commented Aug 14, 2024

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 14, 2024
@cost0much
Copy link
Contributor Author

/approval request Improves the test added by JDK-8316193 in JDK 22. Applies cleanly. Affected test
passes. Risk is low: the change is test code only.

@openjdk
Copy link

openjdk bot commented Aug 14, 2024

@cost0much
8316193: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 14, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 14, 2024

Webrevs

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Aug 22, 2024
@cost0much
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 23, 2024
@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@cost0much
Your change (at version 71f2cdd) is now ready to be sponsored by a Committer.

@benty-amzn
Copy link

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 23, 2024

Going to push as commit 4f28612.
Since your change was applied there have been 27 commits pushed to the master branch:

  • b8038ea: 8335743: jhsdb jstack cannot print some information on the waiting thread
  • e79f9b4: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
  • 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
  • dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
  • fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
  • d5b8ea8: 8330981: ZGC: Should not dedup strings in the finalizer graph
  • 38eeb50: 8335007: Inline OopMapCache table
  • affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
  • 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
  • cd5ac19: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • ... and 17 more: https://git.openjdk.org/jdk21u-dev/compare/d4a6e72a22cf8cee91dc9553454dd62fe0547b85...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 23, 2024
@openjdk openjdk bot closed this Aug 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 23, 2024
@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@benty-amzn @cost0much Pushed as commit 4f28612.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants