-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak #918
Conversation
👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into |
@cost0much This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Improves the test added by JDK-8316193 in JDK 22. Applies cleanly. Affected test |
@cost0much |
/integrate |
@cost0much |
/sponsor |
Going to push as commit 4f28612.
Your commit was automatically rebased without conflicts. |
@benty-amzn @cost0much Pushed as commit 4f28612. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. Improves jdk/jfr/event/oldobject/TestListenerLeak test making it more robust. Passes tier1 tests on linux x64 and the test itself.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/918/head:pull/918
$ git checkout pull/918
Update a local copy of the PR:
$ git checkout pull/918
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/918/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 918
View PR using the GUI difftool:
$ git pr show -t 918
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/918.diff
Webrev
Link to Webrev Comment