8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0

[cost0much]

Backport that aligns the IR testing framework preconditions rule with JDK22. This mainly aims to make future backports involving the IR testing framework more convenient; more specifically to my use-case, I'd like to backport JDK-8280120 afterwards, and this change precedes that for IREncodingPrinter.java. Not clean because JDK-8310308 has already backported a later fix to VectorLogicalOpIdentityTest.java.

Passes tier1 tests on Linux x86 and the test TestPreconditions.java for the framework rule change.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• JDK-8309894 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0 (Bug - P4 - Approved)

Reviewers

• Paul Hohensee (@phohensee - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/922/head:pull/922
$ git checkout pull/922

Update a local copy of the PR:
$ git checkout pull/922
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/922/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 922

View PR using the GUI difftool:
$ git pr show -t 922

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/922.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cost0much! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cost0much This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309894: compiler/vectorapi/VectorLogicalOpIdentityTest.java fails on SVE system with UseSVE=0

Reviewed-by: phh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

• 4f28612: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• b8038ea: 8335743: jhsdb jstack cannot print some information on the waiting thread
• e79f9b4: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
• dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
• fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
• d5b8ea8: 8330981: ZGC: Should not dedup strings in the finalizer graph
• 38eeb50: 8335007: Inline OopMapCache table
• affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
• 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 01: Full - Incremental (2172e385)
• 00: Full (fcaf9eb0)

[openjdk]

⚠️ @cost0much This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[cost0much]

/approval request Updates the preconditions rule for the IR testing framework to match JDK22. Does not apply cleanly but only due to a prior backport: resolution just involves keeping current code. Risk is very low: only applies to testing framework and no changes to any previous test code.

[openjdk]

@cost0much
8309894: The approval request has been created successfully.

[GoeLin]

Hi,
I had a look at approving this. I don't understand why you omit the Copyright change to the 4th file.

[cost0much]

Hi, I had a look at approving this. I don't understand why you omit the Copyright change to the 4th file.

Ah I assumed that since no other changes were being made to the file, that the Copyright year change should be omitted as well. I'll add it now

[cost0much]

/integrate

[openjdk]

@cost0much
Your change (at version 2172e38) is now ready to be sponsored by a Committer.

[Rudometov]

/sponsor

[openjdk]

Going to push as commit fe47075.
Since your change was applied there have been 10 commits pushed to the master branch:

• 4f28612: 8316193: jdk/jfr/event/oldobject/TestListenerLeak.java java.lang.Exception: Could not find leak
• b8038ea: 8335743: jhsdb jstack cannot print some information on the waiting thread
• e79f9b4: 8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"
• 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
• dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
• fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
• d5b8ea8: 8330981: ZGC: Should not dedup strings in the finalizer graph
• 38eeb50: 8335007: Inline OopMapCache table
• affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
• 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV

Your commit was automatically rebased without conflicts.

[openjdk]

@Rudometov @cost0much Pushed as commit fe47075.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.