Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage #928

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Aug 16, 2024

Backport of 8333149, diff in stride


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333149 needs maintainer approval

Warning

 ⚠️ Found leading lowercase letter in issue title for 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage

Issue

  • JDK-8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/928/head:pull/928
$ git checkout pull/928

Update a local copy of the PR:
$ git checkout pull/928
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/928/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 928

View PR using the GUI difftool:
$ git pr show -t 928

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/928.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 16, 2024

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • ed77abd: 8331572: Allow using OopMapCache outside of STW GC phases
  • fee2094: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension
  • 4e84d4d: 8310683: Refactor StandardCharset/standard.java to use JUnit
  • 9b331b0: 8317738: CodeCacheFullCountTest failed with "VirtualMachineError: Out of space in CodeCache for method handle intrinsic"
  • e7e92e0: 8325022: Incorrect error message on client authentication

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 43a2f17342af8f5bf1f5823df9fa0bf0bdfdfce2 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage Aug 16, 2024
@openjdk
Copy link

openjdk bot commented Aug 16, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 16, 2024

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 16, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 16, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 16, 2024
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

Going to push as commit 24f453c.
Since your change was applied there have been 13 commits pushed to the master branch:

  • dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
  • fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
  • d5b8ea8: 8330981: ZGC: Should not dedup strings in the finalizer graph
  • 38eeb50: 8335007: Inline OopMapCache table
  • affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
  • 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
  • cd5ac19: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • 4c86bf5: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm
  • ed77abd: 8331572: Allow using OopMapCache outside of STW GC phases
  • fee2094: 8330520: linux clang build fails in os_linux.cpp with static_assert with no message is a C++17 extension
  • ... and 3 more: https://git.openjdk.org/jdk21u-dev/compare/d85b7c1e6dafdf02fffb163d924c63710ec43660...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2024
@openjdk openjdk bot closed this Aug 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2024
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@MBaesken Pushed as commit 24f453c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant