8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"

[sendaoYan]

Hi all,

This pull request contains a backport of commit fa7521b2 from the openjdk/jdk repository.

The commit being backported was authored by Erik Gahlin on 24 Jun 2024 and was reviewed by Markus Grönlund.

We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196. Clean backport , test fix only, no risk.

Thanks!

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8323196 needs maintainer approval

Issue

• JDK-8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false" (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/931/head:pull/931
$ git checkout pull/931

Update a local copy of the PR:
$ git checkout pull/931
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/931/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 931

View PR using the GUI difftool:
$ git pr show -t 931

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/931.diff

Webrev

Link to Webrev Comment

[sendaoYan]

/approval request We have observed this test intermittent failure, which seems similar to JDK-8323196. So we want to backport JDK-8323196. Clean backport , test fix only, no risk.

[bridgekeeper]

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8323196: jdk/jfr/api/consumer/filestream/TestOrdered.java failed with "Events are not ordered! Reuse = false"

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 14 new commits pushed to the master branch:

• 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
• dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
• fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
• d5b8ea8: 8330981: ZGC: Should not dedup strings in the finalizer graph
• 38eeb50: 8335007: Inline OopMapCache table
• affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
• 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
• cd5ac19: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
• 4c86bf5: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm
• ed77abd: 8331572: Allow using OopMapCache outside of STW GC phases
• ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/d85b7c1e6dafdf02fffb163d924c63710ec43660...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[openjdk]

@sendaoYan
8323196: The approval request has been created successfully.

[mlbridge]

Webrevs

• 00: Full (2082e2af)

[sendaoYan]

Thanks for the approved.
/integrate

[openjdk]

@sendaoYan
Your change (at version 2082e2a) is now ready to be sponsored by a Committer.

[phohensee]

/sponsor

[openjdk]

Going to push as commit e79f9b4.
Since your change was applied there have been 14 commits pushed to the master branch:

• 24f453c: 8333149: ubsan : memset on nullptr target detected in jvmtiEnvBase.cpp get_object_monitor_usage
• dc8365c: 8333088: ubsan: shenandoahAdaptiveHeuristics.cpp:245:44: runtime error: division by zero
• fa8ef0f: 8333354: ubsan: frame.inline.hpp:91:25: and src/hotspot/share/runtime/frame.inline.hpp:88:29: runtime error: member call on null pointer of type 'const struct SmallRegisterMap'
• d5b8ea8: 8330981: ZGC: Should not dedup strings in the finalizer graph
• 38eeb50: 8335007: Inline OopMapCache table
• affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
• 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
• cd5ac19: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
• 4c86bf5: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm
• ed77abd: 8331572: Allow using OopMapCache outside of STW GC phases
• ... and 4 more: https://git.openjdk.org/jdk21u-dev/compare/d85b7c1e6dafdf02fffb163d924c63710ec43660...master

Your commit was automatically rebased without conflicts.

[openjdk]

@phohensee @sendaoYan Pushed as commit e79f9b4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

[sendaoYan]

Thanks for the sponsor.