-
Notifications
You must be signed in to change notification settings - Fork 120
8335007: Inline OopMapCache table #936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 3 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
|
/approval request Clean backport to improve OopMapCache footprint and performance, and provide a safer ground for OopMapCache backports, including JDK-8335409 bugfix. All tests pass. The change is simple, so the risk is on the lower side. |
/integrate |
Going to push as commit 38eeb50.
Your commit was automatically rebased without conflicts. |
Almost clean backport to improve
OopMapCache
footprint and performance.The conflict is in copyright header years, bots still think this is clean.
Additionally, this is one of few backports that gets
OopMapCache
behavior similar to mainline. This makes JDK-8335409 backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely.Additional testing:
all
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/936/head:pull/936
$ git checkout pull/936
Update a local copy of the PR:
$ git checkout pull/936
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/936/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 936
View PR using the GUI difftool:
$ git pr show -t 936
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/936.diff
Webrev
Link to Webrev Comment