Skip to content

8335007: Inline OopMapCache table #936

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Aug 20, 2024

Almost clean backport to improve OopMapCache footprint and performance.

The conflict is in copyright header years, bots still think this is clean.

Additionally, this is one of few backports that gets OopMapCache behavior similar to mainline. This makes JDK-8335409 backport easier, because it avoids lots of conflicts, resolving which might introduce surprising bugs. Aligning this code with mainline makes accidents less likely.

Additional testing:

  • Linux x86_64 server fastdebug, all

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335007 needs maintainer approval

Issue

  • JDK-8335007: Inline OopMapCache table (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/936/head:pull/936
$ git checkout pull/936

Update a local copy of the PR:
$ git checkout pull/936
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/936/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 936

View PR using the GUI difftool:
$ git pr show -t 936

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/936.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 20, 2024

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335007: Inline OopMapCache table

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 3 new commits pushed to the master branch:

  • 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
  • cd5ac19: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • 4c86bf5: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 50dd962b0d0fe36634d96dbbd9d94fbc34d9ff7f 8335007: Inline OopMapCache table Aug 20, 2024
@openjdk
Copy link

openjdk bot commented Aug 20, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 20, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 20, 2024

Webrevs

@shipilev
Copy link
Member Author

/approval request Clean backport to improve OopMapCache footprint and performance, and provide a safer ground for OopMapCache backports, including JDK-8335409 bugfix. All tests pass. The change is simple, so the risk is on the lower side.

@openjdk
Copy link

openjdk bot commented Aug 20, 2024

@shipilev
8335007: The approval request has been created successfully.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Aug 20, 2024
@shipilev
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Aug 22, 2024

Going to push as commit 38eeb50.
Since your change was applied there have been 4 commits pushed to the master branch:

  • affb895: 8336926: jdk/internal/util/ReferencedKeyTest.java can fail with ConcurrentModificationException
  • 846962d: 8334078: RISC-V: TestIntVect.java fails after JDK-8332153 when running without RVV
  • cd5ac19: 8299813: java/nio/channels/DatagramChannel/Disconnect.java fails with jtreg test timeout due to lost datagram
  • 4c86bf5: 8309067: gtest/AsyncLogGtest.java fails again in stderrOutput_vm

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 22, 2024
@openjdk openjdk bot closed this Aug 22, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 22, 2024
@openjdk
Copy link

openjdk bot commented Aug 22, 2024

@shipilev Pushed as commit 38eeb50.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant