Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 #939

Closed
wants to merge 2 commits into from

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Aug 21, 2024

Hi all,
Test java/nio/channels/DatagramChannel/Disconnect.java compile error: cannot find symbol InetAddress.ofLiteral after JDK-8299813. There is no InetAddress.ofLiteral API in jdk21u and jdk17u, the InetAddress.ofLiteral API was added by JDK-8272215 in jdk22.
Change InetAddress.ofLiteralto InetAddress.getByName, change has been verified, test fix only, no risk.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • JDK-8338748 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/939/head:pull/939
$ git checkout pull/939

Update a local copy of the PR:
$ git checkout pull/939
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/939/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 939

View PR using the GUI difftool:
$ git pr show -t 939

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/939.diff

Webrev

Link to Webrev Comment

…le error: cannot find symbol InetAddress.ofLiteral after JDK-8299813
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 21, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 21, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813

Reviewed-by: sgehwolf

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 36 new commits pushed to the master branch:

  • 40fe61a: 8331864: Update Public Suffix List to 1cbd6e7
  • c66ea3d: 8328723: IP Address error when client enables HTTPS endpoint check on server socket
  • fbdaf08: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf
  • d71aa19: 8326611: Clean up vmTestbase/nsk/stress/stack tests
  • b0cd38b: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option
  • a7e928c: 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result
  • 0738937: 8339248: RISC-V: Remove li64 macro assembler routine and related code
  • 3c6b637: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058
  • 427dba1: Merge
  • 459757e: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
  • ... and 26 more: https://git.openjdk.org/jdk21u-dev/compare/cd5ac19b4966741904314d42c6ee30ac1d9e0ca9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 21, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 21, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/approval request Fix test bug, the change has been verified, test fix only, no risk.

@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@sendaoYan
8338748: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 23, 2024
@shipilev
Copy link
Member

Is this a 17u/21u-specific fix? I believe the style is to prepend the synopsis with [17u, 21u] ... then.

Missing context: JDK-8272215 is only available in JDK 22, this is why this fails.

@sendaoYan
Copy link
Member Author

/issue JDK-8338748

@openjdk openjdk bot changed the title 8338748: Test Disconnect.java compile error: cannot find symbol after JDK-8299813 8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 Aug 23, 2024
@openjdk
Copy link

openjdk bot commented Aug 23, 2024

@sendaoYan This issue is referenced in the PR title - it will now be updated.

@sendaoYan
Copy link
Member Author

Is this a 17u/21u-specific fix? I believe the style is to prepend the synopsis with [17u, 21u] ... then.

Missing context: JDK-8272215 is only available in JDK 22, this is why this fails.

Thanks for the reminding, it's a 17u/21u-specific fix, the jbs title has been updated, and the missing context has been added.

@sendaoYan
Copy link
Member Author

Before this PR has been reviewed, the approval label should not seted.
/approval cancel

@openjdk
Copy link

openjdk bot commented Aug 29, 2024

@sendaoYan
8338748: The approval request has been cancelled successfully.

@openjdk openjdk bot removed the approval label Aug 29, 2024
Copy link
Contributor

@jerboaa jerboaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The point here is, AFAIK, to do parsing without the reverse look-up. The javadoc states for getByName():

The host name can either be a machine name, such as "www.example.com", or a textual representation of its IP address. If a literal IP address is supplied, only the validity of the address format is checked. 

So the replacement seems OK in principle. Did you run the test?

@sendaoYan
Copy link
Member Author

So the replacement seems OK in principle. Did you run the test?

Yes, the change has been verified locally.

@openjdk
Copy link

openjdk bot commented Sep 9, 2024

⚠️ @sendaoYan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@sendaoYan
Copy link
Member Author

Thanks for the review.

/approval request Fix test bug, the change has been verified locally, test fix only, no risk.

@openjdk
Copy link

openjdk bot commented Sep 9, 2024

@sendaoYan
8338748: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 9, 2024
@GoeLin
Copy link
Member

GoeLin commented Sep 10, 2024

GHA failure is the well known ClhsdbFindPC issue. Unrelated.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 10, 2024
@sendaoYan
Copy link
Member Author

The GHA test runner report two failures:

  1. ClhsdbDumpheap.java fails, which has been recorded by JDK-8247940, it's unreleated to this PR.
  2. ClhsdbFindPC.java#no-xcomp-process fails, which has been recorded by JDK-8288429, it's unreleated to this PR.

@sendaoYan
Copy link
Member Author

Thanks all for the review and approved.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 10, 2024
@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@sendaoYan
Your change (at version 125f172) is now ready to be sponsored by a Committer.

@jerboaa
Copy link
Contributor

jerboaa commented Sep 10, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 10, 2024

Going to push as commit ad5656f.
Since your change was applied there have been 36 commits pushed to the master branch:

  • 40fe61a: 8331864: Update Public Suffix List to 1cbd6e7
  • c66ea3d: 8328723: IP Address error when client enables HTTPS endpoint check on server socket
  • fbdaf08: 8336413: gtk headers : Fix typedef redeclaration of GMainContext and GdkPixbuf
  • d71aa19: 8326611: Clean up vmTestbase/nsk/stress/stack tests
  • b0cd38b: 8337331: crash: pinned virtual thread will lead to jvm crash when running with the javaagent option
  • a7e928c: 8317575: AArch64: C2_MacroAssembler::fast_lock uses rscratch1 for cmpxchg result
  • 0738937: 8339248: RISC-V: Remove li64 macro assembler routine and related code
  • 3c6b637: 8338101: remove old remap assertion in map_or_reserve_memory_aligned after JDK-8338058
  • 427dba1: Merge
  • 459757e: 8338139: {ClassLoading,Memory}MXBean::isVerbose methods are inconsistent with their setVerbose methods
  • ... and 26 more: https://git.openjdk.org/jdk21u-dev/compare/cd5ac19b4966741904314d42c6ee30ac1d9e0ca9...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 10, 2024
@openjdk openjdk bot closed this Sep 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 10, 2024
@openjdk
Copy link

openjdk bot commented Sep 10, 2024

@jerboaa @sendaoYan Pushed as commit ad5656f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan sendaoYan deleted the jbs8338748 branch September 10, 2024 07:59
@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants