-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8338748: [17u,21u] Test Disconnect.java compile error: cannot find symbol after JDK-8299813 #939
Conversation
…le error: cannot find symbol InetAddress.ofLiteral after JDK-8299813
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 36 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jerboaa) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
/approval request Fix test bug, the change has been verified, test fix only, no risk. |
@sendaoYan |
Is this a 17u/21u-specific fix? I believe the style is to prepend the synopsis with Missing context: JDK-8272215 is only available in JDK 22, this is why this fails. |
/issue JDK-8338748 |
@sendaoYan This issue is referenced in the PR title - it will now be updated. |
Thanks for the reminding, it's a 17u/21u-specific fix, the jbs title has been updated, and the missing context has been added. |
Before this PR has been reviewed, the approval label should not seted. |
@sendaoYan |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The point here is, AFAIK, to do parsing without the reverse look-up. The javadoc states for getByName()
:
The host name can either be a machine name, such as "www.example.com", or a textual representation of its IP address. If a literal IP address is supplied, only the validity of the address format is checked.
So the replacement seems OK in principle. Did you run the test?
Yes, the change has been verified locally. |
|
Thanks for the review. /approval request Fix test bug, the change has been verified locally, test fix only, no risk. |
@sendaoYan |
GHA failure is the well known ClhsdbFindPC issue. Unrelated. |
The GHA test runner report two failures:
|
Thanks all for the review and approved. |
@sendaoYan |
/sponsor |
Going to push as commit ad5656f.
Your commit was automatically rebased without conflicts. |
@jerboaa @sendaoYan Pushed as commit ad5656f. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks for the sponsor. |
Hi all,
Test
java/nio/channels/DatagramChannel/Disconnect.java
compile error:cannot find symbol InetAddress.ofLiteral
after JDK-8299813. There is noInetAddress.ofLiteral
API in jdk21u and jdk17u, theInetAddress.ofLiteral
API was added by JDK-8272215 in jdk22.Change
InetAddress.ofLiteral
toInetAddress.getByName
, change has been verified, test fix only, no risk.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/939/head:pull/939
$ git checkout pull/939
Update a local copy of the PR:
$ git checkout pull/939
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/939/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 939
View PR using the GUI difftool:
$ git pr show -t 939
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/939.diff
Webrev
Link to Webrev Comment