Skip to content

8337780: RISC-V: C2: Change C calling convention for sp to NS #945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

RealFYang
Copy link
Member

@RealFYang RealFYang commented Aug 25, 2024

Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. Gtest & Tier1-3 tested on linux-riscv64 platform.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8337780 needs maintainer approval

Issue

  • JDK-8337780: RISC-V: C2: Change C calling convention for sp to NS (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/945/head:pull/945
$ git checkout pull/945

Update a local copy of the PR:
$ git checkout pull/945
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 945

View PR using the GUI difftool:
$ git pr show -t 945

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/945.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2024

👋 Welcome back fyang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Aug 25, 2024

@RealFYang This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337780: RISC-V: C2: Change C calling convention for sp to NS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 922360f: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion
  • 38e8bfe: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • fb72870: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64
  • e939761: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • eb80936: 8316895: SeenThread::print_action_queue called on a null pointer
  • b0da5c7: 8338110: Exclude Fingerprinter::do_type from ubsan checks
  • 669c2b4: 8339080: Bump update version for OpenJDK: jdk-21.0.6
  • 33f4d80: 8280120: [IR Framework] Add attribute to @ir to enable/disable IR matching based on the architecture
  • db914b7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
  • 345b417: 8338286: GHA: Demote x86_32 to hotspot build only
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/4f286127b4221c6173f914e22d9ddb9790b1f634...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 53db937dd0766695906dc20c1dbbd3228c02fe1e 8337780: RISC-V: C2: Change C calling convention for sp to NS Aug 25, 2024
@openjdk
Copy link

openjdk bot commented Aug 25, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 25, 2024

⚠️ @RealFYang This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Aug 25, 2024
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2024

Webrevs

@RealFYang
Copy link
Member Author

/approval request Clean backport of JDK-8337780 to reduce frame size by 16 bytes and improve performance for some C2 runtime stubs as we do not have to save sp on the method entry. This is a RISC-V specific change. Tier1-3 tested on linux-riscv64 platform.

@openjdk
Copy link

openjdk bot commented Aug 25, 2024

@RealFYang
8337780: The approval request has been created successfully.

@openjdk openjdk bot added the approval label Aug 25, 2024
@GoeLin
Copy link
Member

GoeLin commented Aug 29, 2024

Please backport to 23 first.

@openjdk openjdk bot removed the approval label Aug 29, 2024
@RealFYang
Copy link
Member Author

Please backport to 23 first.

Ah, I missed that. Will do. Thanks.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 2, 2024
@RealFYang
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 2, 2024

Going to push as commit d78c446.
Since your change was applied there have been 15 commits pushed to the master branch:

  • 922360f: 8338058: map_or_reserve_memory_aligned Windows enhance remap assertion
  • 38e8bfe: 8334567: [test] runtime/os/TestTracePageSizes move ppc handling
  • fb72870: 8319970: AArch64: enable tests compiler/intrinsics/Test(Long|Integer)UnsignedDivMod.java on aarch64
  • e939761: 8336854: CAInterop.java#actalisauthenticationrootca conflicted with /manual and /timeout
  • eb80936: 8316895: SeenThread::print_action_queue called on a null pointer
  • b0da5c7: 8338110: Exclude Fingerprinter::do_type from ubsan checks
  • 669c2b4: 8339080: Bump update version for OpenJDK: jdk-21.0.6
  • 33f4d80: 8280120: [IR Framework] Add attribute to @ir to enable/disable IR matching based on the architecture
  • db914b7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
  • 345b417: 8338286: GHA: Demote x86_32 to hotspot build only
  • ... and 5 more: https://git.openjdk.org/jdk21u-dev/compare/4f286127b4221c6173f914e22d9ddb9790b1f634...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 2, 2024
@openjdk openjdk bot closed this Sep 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 2, 2024
@openjdk
Copy link

openjdk bot commented Sep 2, 2024

@RealFYang Pushed as commit d78c446.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants