8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #955

offamitkumar · 2024-09-05T10:02:23Z

Hi all,

This pull request contains a backport of commit 28de44da from the openjdk/jdk repository.

The commit being backported was authored by Amit Kumar on 5 Sep 2024 and was reviewed by Stefan Karlsson, Vladimir Kozlov and Dean Long.

Thanks!

Progress

Change must not contain extraneous whitespace
Commit message must refer to an issue
JDK-8332461 needs maintainer approval

Warning

⚠️ Found leading lowercase letter in issue title for 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'

Issue

JDK-8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/955/head:pull/955
$ git checkout pull/955

Update a local copy of the PR:
$ git checkout pull/955
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/955/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 955

View PR using the GUI difftool:
$ git pr show -t 955

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/955.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-09-05T10:03:31Z

👋 Welcome back amitkumar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-09-05T10:03:52Z

@offamitkumar This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType'

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 86 new commits pushed to the master branch:

10665ba: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
6967a6b: 8313878: Exclude two compiler/rtm/locking tests on ppc64le
868168c: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
b002ba6: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed
978075f: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
7fd462f: 8339648: ZGC: Division by zero in rule_major_allocation_rate
73c34be: 8340923: The class LogSelection copies uninitialized memory
11dad92: 8340007: Refactor KeyEvent/FunctionKeyTest.java
115b04c: 8338380: Update TLSCommon/interop/AbstractServer to specify an interface to listen for connections
0755f5c: 8339560: Unaddressed comments during code review of JDK-8337664
... and 76 more: https://git.openjdk.org/jdk21u-dev/compare/0738937b5b590544af69b8823d802957f393927a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2024-09-05T10:04:06Z

This backport pull request has now been updated with issue from the original commit.

openjdk · 2024-09-05T10:04:36Z

⚠️ @offamitkumar This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

mlbridge · 2024-09-05T10:07:20Z

Webrevs

00: Full (43b606bc)

offamitkumar · 2024-09-05T10:07:40Z

/approval request this backport is required as UBSAN will complain due to missing enum value "-1", once enabled in the build-configuration.

openjdk · 2024-09-05T10:08:31Z

@offamitkumar
8332461: The approval request has been created successfully.

GoeLin · 2024-09-06T09:02:25Z

You have failing tests.

offamitkumar · 2024-09-11T10:22:27Z

I don't see these failure locally. I am not getting how to merge master to restart the test case, I tried but it's only pushing to local branch not updating the PR. Any suggestion for either merging master branch or re-running the test cases.

offamitkumar · 2024-09-19T07:05:06Z

@GoeLin any insights on this ? I tried to restart the test few times it looks during downloading the artifact it is failing.

In first run this test is failing: serviceability/sa/ClhsdbFindPC.java#no-xcomp-process

I looked into the JTR but not sure if it is at all related to this change.

ClhsdbFindPC_no-xcomp-process.log

offamitkumar · 2024-10-04T10:34:30Z

Hi, Can I get some help here about how to re-start GHA tests ?

CC: @MBaesken

MBaesken · 2024-10-04T10:39:22Z

test failures are unrelated
Unable to download artifact(s): Artifact not found for name: bundles-macos-aarch64-debug
Unable to download artifact(s): Artifact not found for name: bundles-macos-aarch64-debug
infra issues, not your PR

MBaesken · 2024-10-04T10:42:16Z

I clicked on rerun
https://github.com/openjdk-bots/jdk21u-dev/actions/runs/10718181032
(but I think it is not necessary because the failure above was unrelated anyway)

offamitkumar · 2024-10-04T10:51:07Z

In first run this test is failing: serviceability/sa/ClhsdbFindPC.java#no-xcomp-process
I looked into the JTR but not sure if it is at all related to this change.
ClhsdbFindPC_no-xcomp-process.log

Not sure if artefacts are deleted but I got this log from GHA runs. This was shown in the "first run" of GHA jobs. Still I feel that is not related to my changes.

offamitkumar · 2024-10-04T11:01:12Z

@MBaesken, seems like it failed again.

Error: Unable to download artifact(s): Artifact not found for name: bundles-macos-aarch64-debug
        Please ensure that your artifact is not expired and the artifact was uploaded using a compatible version of toolkit/upload-artifact.

So what should I do now ? Rebase and re-run all of them, please also tell how? or apply for maintainer approval marking it as un-related failure?

MBaesken · 2024-10-04T11:36:52Z

I would suggest to just apply for approval.

offamitkumar · 2024-10-04T12:13:48Z

/approval request this backport is required to fix the issue where UBSAN will complain about non-existent value -1 in the enum.

openjdk · 2024-10-04T12:15:29Z

@offamitkumar
8332461: The approval request has been updated successfully.

GoeLin · 2024-10-05T18:15:36Z

Hi, please do 23 first. Removing tag in the meantime.

offamitkumar · 2024-10-10T10:25:44Z

@GoeLin backport to JDK-23 got integrated by openjdk/jdk23u#138.

offamitkumar · 2024-10-10T10:26:59Z

/approval request this backport is required to fix the issue where UBSAN will complain about non-existent value -1 in the enum. Test failure for macos-aarch64 is unrelated to this change

openjdk · 2024-10-10T10:27:48Z

@offamitkumar
8332461: The approval request has been updated successfully.

offamitkumar · 2024-10-11T12:43:32Z

Thanks @GoeLin @MBaesken for help.
/integrate

openjdk · 2024-10-11T12:43:56Z

@offamitkumar
Your change (at version 43b606b) is now ready to be sponsored by a Committer.

MBaesken · 2024-10-11T13:17:12Z

/sponsor

openjdk · 2024-10-11T13:17:51Z

Going to push as commit 21fec60.
Since your change was applied there have been 86 commits pushed to the master branch:

10665ba: 8341562: RISC-V: Generate comments in -XX:+PrintInterpreter to link to source code
6967a6b: 8313878: Exclude two compiler/rtm/locking tests on ppc64le
868168c: 8328021: Convert applet test java/awt/List/SetFontTest/SetFontTest.html to main program
b002ba6: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed
978075f: 8339487: ProcessHandleImpl os_getChildren sysctl call - retry in case of ENOMEM and enhance exception message
7fd462f: 8339648: ZGC: Division by zero in rule_major_allocation_rate
73c34be: 8340923: The class LogSelection copies uninitialized memory
11dad92: 8340007: Refactor KeyEvent/FunctionKeyTest.java
115b04c: 8338380: Update TLSCommon/interop/AbstractServer to specify an interface to listen for connections
0755f5c: 8339560: Unaddressed comments during code review of JDK-8337664
... and 76 more: https://git.openjdk.org/jdk21u-dev/compare/0738937b5b590544af69b8823d802957f393927a...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-10-11T13:18:03Z

@MBaesken @offamitkumar Pushed as commit 21fec60.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Backport 28de44da71871bec7648f01a4df2faee43fa43b6

43b606b

openjdk bot changed the title ~~Backport 28de44da71871bec7648f01a4df2faee43fa43b6~~ 8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' Sep 5, 2024

openjdk bot added backport clean labels Sep 5, 2024

openjdk bot added the rfr Pull request is ready for review label Sep 5, 2024

openjdk bot added the approval label Sep 5, 2024

openjdk bot removed the approval label Sep 6, 2024

openjdk bot added the approval label Oct 4, 2024

openjdk bot removed the approval label Oct 5, 2024

openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Oct 10, 2024

openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 11, 2024

openjdk bot added the integrated Pull request has been integrated label Oct 11, 2024

openjdk bot closed this Oct 11, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 11, 2024

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #955

8332461: ubsan : dependencies.cpp:906:3: runtime error: load of value 4294967295, which is not a valid value for type 'DepType' #955

Uh oh!

Conversation

offamitkumar commented Sep 5, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Warning

Issue

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

mlbridge bot commented Sep 5, 2024

Webrevs

Uh oh!

offamitkumar commented Sep 5, 2024

Uh oh!

openjdk bot commented Sep 5, 2024

Uh oh!

GoeLin commented Sep 6, 2024

Uh oh!

offamitkumar commented Sep 11, 2024

Uh oh!

offamitkumar commented Sep 19, 2024

Uh oh!

offamitkumar commented Oct 4, 2024

Uh oh!

MBaesken commented Oct 4, 2024

Uh oh!

MBaesken commented Oct 4, 2024

Uh oh!

offamitkumar commented Oct 4, 2024

Uh oh!

offamitkumar commented Oct 4, 2024

Uh oh!

MBaesken commented Oct 4, 2024

Uh oh!

offamitkumar commented Oct 4, 2024

Uh oh!

openjdk bot commented Oct 4, 2024

Uh oh!

GoeLin commented Oct 5, 2024

Uh oh!

offamitkumar commented Oct 10, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

offamitkumar commented Oct 10, 2024

Uh oh!

openjdk bot commented Oct 10, 2024

Uh oh!

offamitkumar commented Oct 11, 2024

Uh oh!

openjdk bot commented Oct 11, 2024

Uh oh!

MBaesken commented Oct 11, 2024

Uh oh!

openjdk bot commented Oct 11, 2024

Uh oh!

openjdk bot commented Oct 11, 2024

Uh oh!

Uh oh!

offamitkumar commented Sep 5, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Sep 5, 2024 •

edited

Loading

offamitkumar commented Oct 10, 2024 •

edited

Loading