Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8332340: Add JavacBench as a test case for CDS #970

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 12, 2024

I backport this for parity with 21.0.6-oracle.


Progress

  • JDK-8332340 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8332340: Add JavacBench as a test case for CDS (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/970/head:pull/970
$ git checkout pull/970

Update a local copy of the PR:
$ git checkout pull/970
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/970/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 970

View PR using the GUI difftool:
$ git pr show -t 970

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/970.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332340: Add JavacBench as a test case for CDS

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5162660: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
  • 29b65ab: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 7fd9d6c760c66d3e2f4034cf1a6b1b583ff829a9 8332340: Add JavacBench as a test case for CDS Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 13, 2024

GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 13, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2024

Going to push as commit 2e3ef5f.
Since your change was applied there have been 6 commits pushed to the master branch:

  • 58cc0a2: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless
  • fee1d96: 8326898: NSK tests should listen on loopback addresses only
  • 967a3cd: 8328303: 3 JDI tests timed out with UT enabled
  • c82c70d: 8296787: Unify debug printing format of X.509 cert serial numbers
  • 5162660: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
  • 29b65ab: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2024
@openjdk openjdk bot closed this Sep 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2024
@openjdk
Copy link

openjdk bot commented Sep 16, 2024

@GoeLin Pushed as commit 2e3ef5f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant