Skip to content

8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization#971

Closed
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-b3e29db1-master
Closed

8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization#971
GoeLin wants to merge 1 commit intoopenjdk:masterfrom
openjdk-bots:backport-GoeLin-b3e29db1-master

Conversation

@GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 12, 2024

I backport this for parity with 21.0.6-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8333108 needs maintainer approval

Issue

  • JDK-8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/971/head:pull/971
$ git checkout pull/971

Update a local copy of the PR:
$ git checkout pull/971
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/971/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 971

View PR using the GUI difftool:
$ git pr show -t 971

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/971.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the master branch:

  • 5162660: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
  • 29b65ab: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport b3e29db14466ccc64a2815224ecefab4cec4c775 8333108: Update vmTestbase/nsk/share/DebugeeProcess.java to don't use finalization Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 12, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

@openjdk openjdk bot added approval Requires approval; will be removed when approval is received ready Pull request is ready to be integrated and removed approval Requires approval; will be removed when approval is received labels Sep 13, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 16, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 16, 2024

Going to push as commit 3fc06a2.
Since your change was applied there have been 8 commits pushed to the master branch:

  • 3637991: 8332724: x86 MacroAssembler may over-align code
  • 2e3ef5f: 8332340: Add JavacBench as a test case for CDS
  • 58cc0a2: 8321550: Update several runtime/cds tests to use vm flags or mark as flagless
  • fee1d96: 8326898: NSK tests should listen on loopback addresses only
  • 967a3cd: 8328303: 3 JDI tests timed out with UT enabled
  • c82c70d: 8296787: Unify debug printing format of X.509 cert serial numbers
  • 5162660: 8328665: serviceability/jvmti/vthread/PopFrameTest failed with a timeout
  • 29b65ab: 8312518: [macos13] setFullScreenWindow() shows black screen on macOS 13 & above

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 16, 2024
@openjdk openjdk bot closed this Sep 16, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2024
@openjdk
Copy link

openjdk bot commented Sep 16, 2024

@GoeLin Pushed as commit 3fc06a2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant