Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test #972

Closed
wants to merge 4 commits into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 12, 2024

I backport this for parity with 21.0.6-oracle.

This depends on JDK-8320586, and JDK-8336240, will wait until that is pushed.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8335172 needs maintainer approval

Issue

  • JDK-8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/972/head:pull/972
$ git checkout pull/972

Update a local copy of the PR:
$ git checkout pull/972
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/972/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 972

View PR using the GUI difftool:
$ git pr show -t 972

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/972.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 12, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 12, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport a5c2d7b305407974b3f67c48b8dcb1f8e77abde3 8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test Sep 12, 2024
@openjdk
Copy link

openjdk bot commented Sep 12, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport rfr Pull request is ready for review labels Sep 12, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 12, 2024

Webrevs

@GoeLin
Copy link
Member Author

GoeLin commented Sep 13, 2024

GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940

@GoeLin GoeLin force-pushed the goetz_backport_8335172 branch from 76eb18f to 096cc3b Compare September 23, 2024 07:36
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information.

@openjdk openjdk bot added the clean label Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 23, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 24, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@GoeLin Since your change was applied there have been 5 commits pushed to the master branch:

  • b5c3d76: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
  • b0fb742: 8335530: Java file extension missing in AuthenticatorTest
  • df2d31f: 8325399: Add tests for virtual threads doing Selector operations
  • 87aa1dd: 8326121: vmTestbase/gc/g1/unloading/tests/unloading_keepRef_rootClass_inMemoryCompilation_keep_cl failed with Full gc happened. Test was useless.
  • a5e7c32: 8339416: [s390x] Provide implementation for resolve_global_jobject

It was not possible to rebase your changes automatically. Please merge master into your branch and try again.

@GoeLin
Copy link
Member Author

GoeLin commented Sep 24, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 24, 2024

Going to push as commit 41f7936.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 24, 2024
@openjdk openjdk bot closed this Sep 24, 2024
@openjdk openjdk bot removed the ready Pull request is ready to be integrated label Sep 24, 2024
@GoeLin GoeLin deleted the goetz_backport_8335172 branch September 24, 2024 08:08
@openjdk openjdk bot removed the rfr Pull request is ready for review label Sep 24, 2024
@openjdk
Copy link

openjdk bot commented Sep 24, 2024

@GoeLin Pushed as commit 41f7936.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant