-
Notifications
You must be signed in to change notification settings - Fork 114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test #972
Conversation
👋 Welcome back goetz! A progress list of the required criteria for merging this PR into |
@GoeLin This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
Webrevs
|
GHA failure: Well known issue with Clhsdb* tests, see also https://bugs.openjdk.org/browse/JDK-8247940 |
76eb18f
to
096cc3b
Compare
@GoeLin Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
/integrate |
@GoeLin Since your change was applied there have been 5 commits pushed to the
It was not possible to rebase your changes automatically. Please merge |
/integrate |
Going to push as commit 41f7936. |
I backport this for parity with 21.0.6-oracle.
This depends on JDK-8320586, and JDK-8336240, will wait until that is pushed.
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/972/head:pull/972
$ git checkout pull/972
Update a local copy of the PR:
$ git checkout pull/972
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/972/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 972
View PR using the GUI difftool:
$ git pr show -t 972
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/972.diff
Webrev
Link to Webrev Comment