Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile #995

Closed

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 20, 2024

I backport this for parity with 21.0.6-oracle.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8321616 needs maintainer approval
  • JDK-8322830 needs maintainer approval

Issues

  • JDK-8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile (Enhancement - P4 - Approved)
  • JDK-8322830: Add test case for ZipFile opening a ZIP with no entries (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u-dev.git pull/995/head:pull/995
$ git checkout pull/995

Update a local copy of the PR:
$ git checkout pull/995
$ git pull https://git.openjdk.org/jdk21u-dev.git pull/995/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 995

View PR using the GUI difftool:
$ git pr show -t 995

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u-dev/pull/995.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2024

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile
8322830: Add test case for ZipFile opening a ZIP with no entries

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 816706c: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 26de9e247a6ed1c0b8b247d77514ed16905d7c48 8321616: Retire binary test vectors in test/jdk/java/util/zip/ZipFile Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 20, 2024

Webrevs

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed approval labels Sep 21, 2024
@GoeLin
Copy link
Member Author

GoeLin commented Sep 23, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Sep 23, 2024

Going to push as commit ad78384.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 0a7aa3d: 8320586: update manual test/jdk/TEST.groups
  • 816706c: 8322166: Files.isReadable/isWritable/isExecutable expensive when file does not exist

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 23, 2024
@openjdk openjdk bot closed this Sep 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 23, 2024
@openjdk
Copy link

openjdk bot commented Sep 23, 2024

@GoeLin Pushed as commit ad78384.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant