-
Notifications
You must be signed in to change notification settings - Fork 135
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
8317510: Change Windows debug symbol files naming to avoid losing inf…
…o when an executable and a library share the same name Backport-of: d96f38b80c1606b54b9f3dbfe9717ab9653a0605
- Loading branch information
Showing
8 changed files
with
99 additions
and
36 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
76 changes: 76 additions & 0 deletions
76
test/hotspot/jtreg/runtime/ErrorHandling/TestSymbolsInHsErrFile.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /* | ||
| * Copyright (c) 2023, Oracle and/or its affiliates. All rights reserved. | ||
| * Copyright (c) 2023, Red Hat, Inc. All rights reserved. | ||
| * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. | ||
| * | ||
| * This code is free software; you can redistribute it and/or modify it | ||
| * under the terms of the GNU General Public License version 2 only, as | ||
| * published by the Free Software Foundation. | ||
| * | ||
| * This code is distributed in the hope that it will be useful, but WITHOUT | ||
| * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or | ||
| * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License | ||
| * version 2 for more details (a copy is included in the LICENSE file that | ||
| * accompanied this code). | ||
| * | ||
| * You should have received a copy of the GNU General Public License version | ||
| * 2 along with this work; if not, write to the Free Software Foundation, | ||
| * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. | ||
| * | ||
| * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA | ||
| * or visit www.oracle.com if you need additional information or have any | ||
| * questions. | ||
| */ | ||
|
|
||
|
|
||
| /* | ||
| * @test symbolsHsErr | ||
| * @summary Test that function names are present in native frames of hs-err file as a proof that symbols are available. | ||
| * @library /test/lib | ||
| * @requires vm.flagless | ||
| * @requires vm.debug | ||
| * @requires os.family == "windows" | ||
| * @modules java.base/jdk.internal.misc | ||
| * java.management | ||
| * @run driver TestSymbolsInHsErrFile | ||
| */ | ||
|
|
||
| import jdk.test.lib.process.OutputAnalyzer; | ||
| import jdk.test.lib.process.ProcessTools; | ||
|
|
||
| public class TestSymbolsInHsErrFile { | ||
|
|
||
| public static void main(String[] args) throws Exception { | ||
|
|
||
| // Start a jvm and cause a SIGSEGV / ACCESS_VIOLATION | ||
| ProcessBuilder pb = ProcessTools.createJavaProcessBuilder( | ||
| "-XX:+UnlockDiagnosticVMOptions", | ||
| "-Xmx100M", | ||
| "-XX:-CreateCoredumpOnCrash", | ||
| "-XX:ErrorHandlerTest=14", | ||
| "-version"); | ||
|
|
||
| OutputAnalyzer output = new OutputAnalyzer(pb.start()); | ||
| output.shouldNotHaveExitValue(0); | ||
|
|
||
| // Verify that the hs_err problematic frame contains a function name that points to origin of the crash; | ||
| // on Windows/MSVC, if symbols are present and loaded, we should see a ref to either 'crash_with_segfault' | ||
| // 'VMError::controlled_crash' depending on whether the compile optimizations (i.e. crash_with_segfault | ||
| // was inlined or not): | ||
| // # Problematic frame: | ||
| // # V [jvm.dll+0x.....] crash_with_segfault+0x10 | ||
| // or | ||
| // # V [jvm.dll+0x.....] VMError::controlled_crash+0x99 | ||
| // | ||
| // If symbols could not be loaded, however, then the frame will contain not function name at all, i.e. | ||
| // # Problematic frame: | ||
| // # V [jvm.dll+0x.....] | ||
| // NB: this is not true for other OS/Compilers, where the functions names are present even with no symbols, | ||
| // hence this test being restricted to Windows only. | ||
| output.shouldMatch(("# V \\[jvm.dll.*\\].*(crash_with_segfault|controlled_crash).*")); | ||
|
|
||
| } | ||
|
|
||
| } | ||
|
|
||
|
|
32987b7There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review
Issues