Skip to content

Commit

Permalink
8318089: Class space not marked as such with NMT when CDS is off
Browse files Browse the repository at this point in the history
Backport-of: c0e154c876e586660b36af6441cd178bc8ebab89
  • Loading branch information
tstuefe committed Nov 2, 2023
1 parent 6e21766 commit bb8db71
Showing 1 changed file with 3 additions and 6 deletions.
9 changes: 3 additions & 6 deletions src/hotspot/share/memory/metaspace.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -567,12 +567,6 @@ void Metaspace::initialize_class_space(ReservedSpace rs) {
"wrong alignment");

MetaspaceContext::initialize_class_space_context(rs);

// This does currently not work because rs may be the result of a split
// operation and NMT seems not to be able to handle splits.
// Will be fixed with JDK-8243535.
// MemTracker::record_virtual_memory_type((address)rs.base(), mtClass);

}

// Returns true if class space has been setup (initialize_class_space).
Expand Down Expand Up @@ -837,6 +831,9 @@ void Metaspace::global_initialize() {
CompressedClassSpaceSize));
}

// Mark class space as such
MemTracker::record_virtual_memory_type((address)rs.base(), mtClass);

// Initialize space
Metaspace::initialize_class_space(rs);

Expand Down

1 comment on commit bb8db71

@openjdk-notifier
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please sign in to comment.