Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. #106

Closed

Conversation

sid8606
Copy link
Member

@sid8606 sid8606 commented Aug 25, 2023

Hi all,

This pull request contains a backport of commit 514816ed from the openjdk/jdk repository.

The commit being backported was authored by Sidraya Jayagond on 4 Jul 2023 and was reviewed by Amit Kumar and Lutz Schmidt.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/106/head:pull/106
$ git checkout pull/106

Update a local copy of the PR:
$ git checkout pull/106
$ git pull https://git.openjdk.org/jdk21u.git pull/106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 106

View PR using the GUI difftool:
$ git pr show -t 106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/106.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 25, 2023

👋 Welcome back sjayagond! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 514816ed7d7dea1fb13d32b80aef89774bee13d3 8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch. Aug 25, 2023
@openjdk
Copy link

openjdk bot commented Aug 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 25, 2023

@sid8606 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309889: [s390] Missing return statement after calling jump_to_native_invoker method in generate_method_handle_dispatch.

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • 3f889a8: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 4909911: 8314960: Add Certigna Root CA - 2
  • f5eef20: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • 46ce555: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • b96aa3c: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • a34b844: 8313701: GHA: RISC-V should use the official repository for bootstrap

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 25, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 25, 2023

Webrevs

@sid8606
Copy link
Member Author

sid8606 commented Aug 28, 2023

Since this is a trivial change, I Will integrate it directly integrate.
Can somebody sponsor this PR?

@sid8606
Copy link
Member Author

sid8606 commented Aug 28, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@sid8606
Your change (at version 8fc8819) is now ready to be sponsored by a Committer.

@offamitkumar
Copy link
Member

I'll sponser this once we got approval.

@offamitkumar
Copy link
Member

Fix Approved !!

@TheRealMDoerr
Copy link
Contributor

I think only jdk-updates committers can sponsor it. I'll do it.
/sponsor

@openjdk
Copy link

openjdk bot commented Aug 28, 2023

Going to push as commit 8bf3ba3.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 2408df2: 8309475: Test java/foreign/TestByteBuffer.java fails: a problem with msync (aix)
  • 1f5ba7a: 8314063: The socket is not closed in Connection::createSocket when the handshake failed for LDAP connection
  • 34e9be5: 8312620: WSL Linux build crashes after JDK-8310233
  • 4cca633: 8312182: THPs cause huge RSS due to thread start timing issue
  • 89234bc: 8303815: Improve Metaspace test speed
  • 3f889a8: 8312394: [linux] SIGSEGV if kernel was built without hugepage support
  • 4909911: 8314960: Add Certigna Root CA - 2
  • f5eef20: 8314850: SharedRuntime::handle_wrong_method() gets called too often when resolving Continuation.enter
  • 46ce555: 8313796: AsyncGetCallTrace crash on unreadable interpreter method pointer
  • b96aa3c: 8311592: ECKeySizeParameterSpec causes too many exceptions on third party providers
  • ... and 1 more: https://git.openjdk.org/jdk21u/compare/c849fa5b1fe52ff92588762fb739253d6f2044b6...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 28, 2023
@openjdk openjdk bot closed this Aug 28, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 28, 2023
@openjdk
Copy link

openjdk bot commented Aug 28, 2023

@TheRealMDoerr @sid8606 Pushed as commit 8bf3ba3.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants