Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError #11

Closed
wants to merge 1 commit into from

Conversation

johnyjose30
Copy link
Contributor

@johnyjose30 johnyjose30 commented Jul 18, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/11/head:pull/11
$ git checkout pull/11

Update a local copy of the PR:
$ git checkout pull/11
$ git pull https://git.openjdk.org/jdk21u.git pull/11/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 11

View PR using the GUI difftool:
$ git pr show -t 11

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/11.diff

Webrev

Link to Webrev Comment

@bridgekeeper bridgekeeper bot added the oca Needs verification of OCA signatory status label Jul 18, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 18, 2023

Hi @johnyjose30, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user johnyjose30" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

@openjdk openjdk bot changed the title Backport 268ec61d4fa9c5b7d2c7bcafb942b33e5b189974 8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError Jul 18, 2023
@openjdk
Copy link

openjdk bot commented Jul 18, 2023

This backport pull request has now been updated with issue from the original commit.

@bridgekeeper bridgekeeper bot removed the oca Needs verification of OCA signatory status label Jul 18, 2023
@openjdk
Copy link

openjdk bot commented Jul 18, 2023

@johnyjose30 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308184: Launching java with large number of jars in classpath with java.protocol.handler.pkgs system property set can lead to StackOverflowError

Reviewed-by: jpai, coffeys

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@coffeys) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 18, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 18, 2023

Webrevs

@johnyjose30 johnyjose30 marked this pull request as draft July 19, 2023 04:18
@johnyjose30 johnyjose30 marked this pull request as ready for review July 19, 2023 04:18
@johnyjose30
Copy link
Contributor Author

Reviewers: @coffeys @jaikiran

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The backport looks good to me.

@coffeys
Copy link
Contributor

coffeys commented Jul 19, 2023

Looks fine Johny. Please consider using the "/backport" feature of Skara for such ports in future.

@johnyjose30
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 19, 2023
@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@johnyjose30
Your change (at version 9fc2b2d) is now ready to be sponsored by a Committer.

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 19, 2023

@jaikiran Only Committers are allowed to sponsor changes.

@coffeys
Copy link
Contributor

coffeys commented Jul 19, 2023

let's hold off on sponsor operation until Johny gets the necessary approval to push to the jdk updates repo. (fix request still pending)

@coffeys
Copy link
Contributor

coffeys commented Jul 20, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 20, 2023

Going to push as commit 7f658ce.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 1776b3d: 8311862: RISC-V: small improvements to shift immediate instructions

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 20, 2023
@openjdk openjdk bot closed this Jul 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 20, 2023
@openjdk openjdk bot removed the sponsor Pull request is ready to be sponsored label Jul 20, 2023
@openjdk
Copy link

openjdk bot commented Jul 20, 2023

@coffeys @johnyjose30 Pushed as commit 7f658ce.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants