-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8308593: Add KEEPALIVE Extended Socket Options Support for Windows #117
Conversation
👋 Welcome back tkyc! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@tkyc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 40 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
/integrate |
Hello, JBS issue was tagged with maintainer approval. |
/sponsor |
Going to push as commit 1927930.
Your commit was automatically rebased without conflicts. |
This is a clean backport of JDK-8308593, which provides support for the keepalive extended socket options on Windows.
Tier 1 tests were ran and they're passing along with the existing keepalive tests. I also manually tested and confirmed the patch to be working on Windows (specifically Windows 10 since that's the only Windows platform available to me at the moment).
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/117/head:pull/117
$ git checkout pull/117
Update a local copy of the PR:
$ git checkout pull/117
$ git pull https://git.openjdk.org/jdk21u.git pull/117/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 117
View PR using the GUI difftool:
$ git pr show -t 117
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/117.diff
Webrev
Link to Webrev Comment