Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8299658: C1 compilation crashes in LinearScan::resolve_exception_edge #119

Conversation

TheRealMDoerr
Copy link
Contributor

@TheRealMDoerr TheRealMDoerr commented Aug 31, 2023

Clean backport of JDK-8299658.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8299658: C1 compilation crashes in LinearScan::resolve_exception_edge (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/119/head:pull/119
$ git checkout pull/119

Update a local copy of the PR:
$ git checkout pull/119
$ git pull https://git.openjdk.org/jdk21u.git pull/119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 119

View PR using the GUI difftool:
$ git pr show -t 119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/119.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Aug 31, 2023

👋 Welcome back mdoerr! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport cf2d33ca2ee08c61596ab10b7602500a6931fa31 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge Aug 31, 2023
@openjdk
Copy link

openjdk bot commented Aug 31, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Aug 31, 2023

@TheRealMDoerr This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8299658: C1 compilation crashes in LinearScan::resolve_exception_edge

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 31, 2023
@mlbridge
Copy link

mlbridge bot commented Aug 31, 2023

Webrevs

@TheRealMDoerr
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 4, 2023

Going to push as commit fbc194a.
Since your change was applied there have been 6 commits pushed to the master branch:

  • b86a0ce: 8309032: jpackage does not work for module projects unless --module-path is specified
  • efb11c1: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • 91e37e9: 8311033: [macos] PrinterJob does not take into account Sides attribute
  • 72980bd: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs
  • 233076e: 8313626: C2 crash due to unexpected exception control flow
  • 33ce611: 8315020: The macro definition for LoongArch64 zero build is not accurate.

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2023
@openjdk openjdk bot closed this Sep 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@TheRealMDoerr Pushed as commit fbc194a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@TheRealMDoerr TheRealMDoerr deleted the TheRealMDoerr-backport-cf2d33ca branch September 4, 2023 20:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant