Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315206: RISC-V: hwprobe query is_set return wrong value #121

Closed
wants to merge 1 commit into from

Conversation

robehn
Copy link
Contributor

@robehn robehn commented Sep 1, 2023

Hi all,

This pull request contains a backport of commit 876a725a from the openjdk/jdk repository.

The commit being backported was authored by Robbin Ehn on 30 Aug 2023 and was reviewed by Ludovic Henry and Fei Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315206: RISC-V: hwprobe query is_set return wrong value (Bug - P2)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/121/head:pull/121
$ git checkout pull/121

Update a local copy of the PR:
$ git checkout pull/121
$ git pull https://git.openjdk.org/jdk21u.git pull/121/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 121

View PR using the GUI difftool:
$ git pr show -t 121

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/121.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2023

👋 Welcome back rehn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 876a725af95d65d59390c86bfec64c33cccbf53b 8315206: RISC-V: hwprobe query is_set return wrong value Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@robehn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315206: RISC-V: hwprobe query is_set return wrong value

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • f07c8f2: 8315688: Update jdk21u fix version to 21.0.2
  • 49bef91: 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
  • a4d64ab: 8315534: Incorrect warnings about implicit annotation processing
  • fbc194a: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • b86a0ce: 8309032: jpackage does not work for module projects unless --module-path is specified
  • efb11c1: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • 91e37e9: 8311033: [macos] PrinterJob does not take into account Sides attribute
  • 72980bd: 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs
  • 233076e: 8313626: C2 crash due to unexpected exception control flow

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2023

Webrevs

@robehn
Copy link
Contributor Author

robehn commented Sep 6, 2023

@RealFYang @luhenry remember to review this if we want it backported!

@RealFYang
Copy link
Member

@RealFYang @luhenry remember to review this if we want it backported!

The bot says it's clean backport and I see jdk21u push approval is granted. So I think you are ready to integrate :-)

@robehn
Copy link
Contributor Author

robehn commented Sep 6, 2023

@RealFYang @luhenry remember to review this if we want it backported!

The bot says it's clean backport and I see jdk21u push approval is granted. So I think you are ready to integrate :-)

I thought what Alan said here:
openjdk/jdk21#67 (comment)

Applied to jdk21u also :)

If not:
/integrate

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@robehn Unknown command intergate - for a list of valid commands use /help.

@RealFYang
Copy link
Member

@RealFYang @luhenry remember to review this if we want it backported!

The bot says it's clean backport and I see jdk21u push approval is granted. So I think you are ready to integrate :-)

I thought what Alan said here: openjdk/jdk21#67 (comment)

Applied to jdk21u also :)

If not: /integrate

I think that rule only applies to release stabilization repositories like jdk20 [1] or jdk21 [2].
BTW: You will need to type /integrate again to get this committed.

[1] https://git.openjdk.org/jdk20
[2] https://git.openjdk.org/jdk21

@robehn
Copy link
Contributor Author

robehn commented Sep 6, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

Going to push as commit 8477ff8.
Since your change was applied there have been 13 commits pushed to the master branch:

  • aef25fc: 8315452: Erroneous AST missing modifiers for partial input
  • 6e54e82: 8314495: Update to use jtreg 7.3.1
  • b207ce7: 8315383: jlink SystemModulesPlugin incorrectly parses the options
  • f1e8b19: 8313167: Update to use jtreg 7.3
  • f07c8f2: 8315688: Update jdk21u fix version to 21.0.2
  • 49bef91: 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
  • a4d64ab: 8315534: Incorrect warnings about implicit annotation processing
  • fbc194a: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • b86a0ce: 8309032: jpackage does not work for module projects unless --module-path is specified
  • efb11c1: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • ... and 3 more: https://git.openjdk.org/jdk21u/compare/33ce611eb78e2b4a36325e4c697cdd875c4d4a6e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 6, 2023
@openjdk openjdk bot closed this Sep 6, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@robehn Pushed as commit 8477ff8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants