-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315206: RISC-V: hwprobe query is_set return wrong value #121
Conversation
👋 Welcome back rehn! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@robehn This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 9 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
@RealFYang @luhenry remember to review this if we want it backported! |
The bot says it's clean backport and I see jdk21u push approval is granted. So I think you are ready to integrate :-) |
I thought what Alan said here: Applied to jdk21u also :) If not: |
@robehn Unknown command |
I think that rule only applies to release stabilization repositories like jdk20 [1] or jdk21 [2]. [1] https://git.openjdk.org/jdk20 |
/integrate |
Going to push as commit 8477ff8.
Your commit was automatically rebased without conflicts. |
Hi all,
This pull request contains a backport of commit 876a725a from the openjdk/jdk repository.
The commit being backported was authored by Robbin Ehn on 30 Aug 2023 and was reviewed by Ludovic Henry and Fei Yang.
Thanks!
Progress
Issue
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/121/head:pull/121
$ git checkout pull/121
Update a local copy of the PR:
$ git checkout pull/121
$ git pull https://git.openjdk.org/jdk21u.git pull/121/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 121
View PR using the GUI difftool:
$ git pr show -t 121
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/121.diff
Webrev
Link to Webrev Comment