Conversation
|
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
7513dbd to
e44fcd1
Compare
|
The parent pull request that this pull request depends on has now been integrated and the target branch of this pull request has been updated. This means that changes from the dependent pull request can start to show up as belonging to this pull request, which may be confusing for reviewers. To remedy this situation, simply merge the latest changes from the new target branch into this pull request by running commands similar to these in the local repository for your personal fork: git checkout JDK-8314495-jtreg-7.3.1
git fetch https://git.openjdk.org/jdk21u.git master
git merge FETCH_HEAD
# if there are conflicts, follow the instructions given by git merge
git commit -m "Merge master"
git push |
|
@shipilev Please do not rebase or force-push to an active PR as it invalidates existing review comments. Note for future reference, the bots always squash all changes into a single commit automatically as part of the integration. See OpenJDK Developers’ Guide for more information. |
|
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
|
Previous GHA was green. Current GHA had a least one test suite completed. Push approval granted. /integrate |
Unclean backport to bring jtreg version in alignment with mainline. The uncleanliness comes from contextual difference re gtest version in the adjacent hunks.
Additional testing:
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/123/head:pull/123$ git checkout pull/123Update a local copy of the PR:
$ git checkout pull/123$ git pull https://git.openjdk.org/jdk21u.git pull/123/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 123View PR using the GUI difftool:
$ git pr show -t 123Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/123.diff
Webrev
Link to Webrev Comment