Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs #125

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 1, 2023

Clean backport to fix the failing test.

Additional testing:

  • Affected test used to fail, now passes

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/125/head:pull/125
$ git checkout pull/125

Update a local copy of the PR:
$ git checkout pull/125
$ git pull https://git.openjdk.org/jdk21u.git pull/125/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 125

View PR using the GUI difftool:
$ git pr show -t 125

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/125.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 1, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 145d8bc1a3ef4f4fe0c10385be111838e7ed9250 8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs Sep 1, 2023
@openjdk
Copy link

openjdk bot commented Sep 1, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 1, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315051: jdk/jfr/jvm/TestGetEventWriter.java fails with non-JVMCI GCs

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 233076e: 8313626: C2 crash due to unexpected exception control flow
  • 33ce611: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 5589b9e: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • 5cd6929: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701
  • 70c05d1: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
  • d55535d: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
  • bb1adb1: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • c7cff81: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • 071ec8d: 8313691: use close after failing os::fdopen in vmError and ciEnv

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 1, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 1, 2023

Webrevs

@shipilev
Copy link
Member Author

shipilev commented Sep 4, 2023

Testing is clean. Push approval granted.

/integrate

@openjdk
Copy link

openjdk bot commented Sep 4, 2023

Going to push as commit 72980bd.
Since your change was applied there have been 9 commits pushed to the master branch:

  • 233076e: 8313626: C2 crash due to unexpected exception control flow
  • 33ce611: 8315020: The macro definition for LoongArch64 zero build is not accurate.
  • 5589b9e: 8312585: Rename DisableTHPStackMitigation flag to THPStackMitigation
  • 5cd6929: 8314656: GHA: No need for Debian ports keyring installation after JDK-8313701
  • 70c05d1: 8312535: MidiSystem.getSoundbank() throws unexpected SecurityException
  • d55535d: 8308042: [macos] Developer ID Application Certificate not picked up by jpackage if it contains UNICODE characters
  • bb1adb1: 8314679: SA fails to properly attach to JVM after having just detached from a different JVM
  • c7cff81: 8312489: Increase jdk.jar.maxSignatureFileSize default which is too low for JARs such as WhiteSource/Mend unified agent jar
  • 071ec8d: 8313691: use close after failing os::fdopen in vmError and ciEnv

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 4, 2023
@openjdk openjdk bot closed this Sep 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@shipilev Pushed as commit 72980bd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8315051-jfr-nonjvmci-gc branch September 11, 2023 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant