Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8242152: SA does not include StackMapTables when dumping .class files #129

Closed
wants to merge 1 commit into from

Conversation

wkia
Copy link

@wkia wkia commented Sep 4, 2023

Clean backport.
Tests in "serviceability/sa" run locallly on Linux (because of GHA skips these tests on Linux with SkippedException) - passed.

NOTE that this is a PR chain, "serviceability/sa/ClhsdbDumpclass" will fail until the next PR #130 is integrated.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8242152 needs maintainer approval

Issue

  • JDK-8242152: SA does not include StackMapTables when dumping .class files (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/129/head:pull/129
$ git checkout pull/129

Update a local copy of the PR:
$ git checkout pull/129
$ git pull https://git.openjdk.org/jdk21u.git pull/129/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 129

View PR using the GUI difftool:
$ git pr show -t 129

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/129.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2023

👋 Welcome back rmarchenko! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8e047029e811a9e5758d564249ee794f584c9dc2 8242152: SA does not include StackMapTables when dumping .class files Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@wkia This change is no longer ready for integration - check the PR body for details.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

⚠️ @wkia This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated approval labels Sep 21, 2023
@wkia
Copy link
Author

wkia commented Sep 23, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 23, 2023
@openjdk
Copy link

openjdk bot commented Sep 23, 2023

@wkia
Your change (at version ddc96a6) is now ready to be sponsored by a Committer.

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@bridgekeeper
Copy link

bridgekeeper bot commented Dec 12, 2023

@wkia This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

@bridgekeeper bridgekeeper bot closed this Dec 12, 2023
@wkia
Copy link
Author

wkia commented Dec 12, 2023

/open

@openjdk openjdk bot reopened this Dec 12, 2023
@openjdk
Copy link

openjdk bot commented Dec 12, 2023

@wkia This pull request is now open

@openjdk openjdk bot added approval and removed sponsor Pull request is ready to be sponsored ready Pull request is ready to be integrated labels Dec 15, 2023
@jerboaa
Copy link
Contributor

jerboaa commented Dec 15, 2023

@wkia This PR needs to move to 21u-dev for 21.0.3 integration. jdk21u is currently closed for pushes. Once created, please re-apply for approval.

@jerboaa
Copy link
Contributor

jerboaa commented Dec 15, 2023

This PR should be closed, btw.

@openjdk openjdk bot removed the approval label Dec 15, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 12, 2024

@wkia This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@GoeLin
Copy link
Member

GoeLin commented Feb 7, 2024

Hi @wkia, please close this PR.

You need to backport this to jdk21u-dev if you want to get it into 21. That is the development repo.

@wkia wkia closed this Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean rfr Pull request is ready for review
3 participants