Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8293114: JVM should trim the native heap #13

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Jul 21, 2023

Clean backport to get the important feature to LTS users.

Additional testing:

  • Linux AArch64 fastdebug trimming tests
  • Linux AArch64 fastdebug tier1
  • Linux AArch64 fastdebug tier2
  • Linux AArch64 fastdebug tier3

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8293114: JVM should trim the native heap (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/13/head:pull/13
$ git checkout pull/13

Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jdk21u.git pull/13/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 13

View PR using the GUI difftool:
$ git pr show -t 13

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/13.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 21, 2023

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 9e4fc568a6f1a93c84a84d6cc5220c6eb4e546a5 8293114: JVM should trim the native heap Jul 21, 2023
@openjdk
Copy link

openjdk bot commented Jul 21, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 21, 2023

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8293114: JVM should trim the native heap

Reviewed-by: stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 21, 2023
@mlbridge
Copy link

mlbridge bot commented Jul 21, 2023

Webrevs

@dholmes-ora
Copy link
Member

dholmes-ora commented Jul 21, 2023

FYI the test is failing for us in mainline JDK-8312525

@shipilev
Copy link
Member Author

FYI the test is failing for us in mainline JDK-8312525

Yup, that one should be resolved by #26.

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good + Thanks!

Same as for 17, I would let it steam a bit in 22, if for no other reason than to see if other intermittent issues come up.

@shipilev
Copy link
Member Author

shipilev commented Aug 9, 2023

I think we are ready for 21u, @tstuefe?

@tstuefe
Copy link
Member

tstuefe commented Aug 9, 2023

I think so too. No new issues have crept up. Thanks for doing this!

@shipilev
Copy link
Member Author

Tests are clean. Review is done. Push approval is here.

/integrate

@openjdk
Copy link

openjdk bot commented Aug 10, 2023

Going to push as commit a094e93.
Since your change was applied there have been 2 commits pushed to the master branch:

  • 588036a: 8308047: java/util/concurrent/ScheduledThreadPoolExecutor/BasicCancelTest.java timed out and also had jcmd pipe errors
  • fd1f47c: 8313676: Amend TestLoadIndexedMismatch test to target intrinsic directly

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 10, 2023
@openjdk openjdk bot closed this Aug 10, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 10, 2023
@openjdk
Copy link

openjdk bot commented Aug 10, 2023

@shipilev Pushed as commit a094e93.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8293114-trim-native-heap branch August 24, 2023 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
3 participants