-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8293114: JVM should trim the native heap #13
Conversation
👋 Welcome back shade! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issue from the original commit. |
@shipilev This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
Webrevs
|
FYI the test is failing for us in mainline JDK-8312525 |
Yup, that one should be resolved by #26. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good + Thanks!
Same as for 17, I would let it steam a bit in 22, if for no other reason than to see if other intermittent issues come up.
I think we are ready for 21u, @tstuefe? |
I think so too. No new issues have crept up. Thanks for doing this! |
Tests are clean. Review is done. Push approval is here. /integrate |
Going to push as commit a094e93.
Your commit was automatically rebased without conflicts. |
Clean backport to get the important feature to LTS users.
Additional testing:
tier1
tier2
tier3
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/13/head:pull/13
$ git checkout pull/13
Update a local copy of the PR:
$ git checkout pull/13
$ git pull https://git.openjdk.org/jdk21u.git pull/13/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 13
View PR using the GUI difftool:
$ git pr show -t 13
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/13.diff
Webrev
Link to Webrev Comment