8315452: Erroneous AST missing modifiers for partial input

[lahodaj]

This is a backport of:
openjdk/jdk@84425a6

The change in JavacParser backported cleanly, the change in the test required a very simple merge, due to the branches diverging.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8315452: Erroneous AST missing modifiers for partial input (Bug - P3)

Reviewers

• Adam Sotona (@asotona - no project role)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/131/head:pull/131
$ git checkout pull/131

Update a local copy of the PR:
$ git checkout pull/131
$ git pull https://git.openjdk.org/jdk21u.git pull/131/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 131

View PR using the GUI difftool:
$ git pr show -t 131

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/131.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[mlbridge]

Webrevs

• 00: Full (699f65bc)

[asotona]

looks good 👍

[vicente-romero-oracle]

looks good

[openjdk]

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315452: Erroneous AST missing modifiers for partial input

Reviewed-by: asotona, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• f1e8b19: 8313167: Update to use jtreg 7.3
• f07c8f2: 8315688: Update jdk21u fix version to 21.0.2
• 49bef91: 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
• a4d64ab: 8315534: Incorrect warnings about implicit annotation processing
• fbc194a: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
• b86a0ce: 8309032: jpackage does not work for module projects unless --module-path is specified
• efb11c1: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[lahodaj]

/integrate

[openjdk]

Going to push as commit aef25fc.
Since your change was applied there have been 9 commits pushed to the master branch:

• 6e54e82: 8314495: Update to use jtreg 7.3.1
• b207ce7: 8315383: jlink SystemModulesPlugin incorrectly parses the options
• f1e8b19: 8313167: Update to use jtreg 7.3
• f07c8f2: 8315688: Update jdk21u fix version to 21.0.2
• 49bef91: 8313323: javac -g on a java file which uses unnamed variable leads to ClassFormatError when launching that class
• a4d64ab: 8315534: Incorrect warnings about implicit annotation processing
• fbc194a: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
• b86a0ce: 8309032: jpackage does not work for module projects unless --module-path is specified
• efb11c1: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj Pushed as commit aef25fc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.