Skip to content

Conversation

@lahodaj
Copy link
Contributor

@lahodaj lahodaj commented Sep 4, 2023

Hi all,

This pull request contains a backport of commit 94a74a0a from the openjdk/jdk repository.

The commit being backported was authored by Jan Lahoda on 4 Sep 2023 and was reviewed by Joe Darcy.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8315534: Incorrect warnings about implicit annotation processing (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/132/head:pull/132
$ git checkout pull/132

Update a local copy of the PR:
$ git checkout pull/132
$ git pull https://git.openjdk.org/jdk21u.git pull/132/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 132

View PR using the GUI difftool:
$ git pr show -t 132

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/132.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 4, 2023

👋 Welcome back jlahoda! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 94a74a0a450cad6080302bc1db15a1a564940bdd 8315534: Incorrect warnings about implicit annotation processing Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required labels Sep 4, 2023
@openjdk
Copy link

openjdk bot commented Sep 4, 2023

@lahodaj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315534: Incorrect warnings about implicit annotation processing

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 91e37e9: 8311033: [macos] PrinterJob does not take into account Sides attribute

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 4, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 4, 2023

Webrevs

@lahodaj
Copy link
Contributor Author

lahodaj commented Sep 5, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

Going to push as commit a4d64ab.
Since your change was applied there have been 4 commits pushed to the master branch:

  • fbc194a: 8299658: C1 compilation crashes in LinearScan::resolve_exception_edge
  • b86a0ce: 8309032: jpackage does not work for module projects unless --module-path is specified
  • efb11c1: 8314024: SIGSEGV in PhaseIdealLoop::build_loop_late_post_work due to bad immediate dominator info
  • 91e37e9: 8311033: [macos] PrinterJob does not take into account Sides attribute

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 5, 2023
@openjdk openjdk bot closed this Sep 5, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@lahodaj Pushed as commit a4d64ab.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport Port of a pull request already in a different code base clean Identical backport; no merge resolution required integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

1 participant