Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8312433: HttpClient request fails due to connection being considered idle and closed #134

Closed
wants to merge 1 commit into from

Conversation

jaikiran
Copy link
Member

@jaikiran jaikiran commented Sep 5, 2023

Backport https://bugs.openjdk.org/browse/JDK-8312433 into JDK 21u.

Not a clean backport because of minor conflict in src/java.net.http/share/classes/jdk/internal/net/http/Http2Connection.java, which has been resolved in this PR.


Progress

  • Change must not contain extraneous whitespace
  • JDK-8312433 needs maintainer approval
  • Commit message must refer to an issue

Issue

  • JDK-8312433: HttpClient request fails due to connection being considered idle and closed (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/134/head:pull/134
$ git checkout pull/134

Update a local copy of the PR:
$ git checkout pull/134
$ git pull https://git.openjdk.org/jdk21u.git pull/134/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 134

View PR using the GUI difftool:
$ git pr show -t 134

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/134.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2023

👋 Welcome back jpai! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@jaikiran
Copy link
Member Author

jaikiran commented Sep 5, 2023

tier1, tier2 and tier3 testing of JDK 21u passed with this change.

@openjdk openjdk bot changed the title Backport 486c7844f902728ce580c3994f58e3e497834952 8312433: HttpClient request fails due to connection being considered idle and closed Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@jaikiran This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312433: HttpClient request fails due to connection being considered idle and closed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 216 new commits pushed to the master branch:

  • c952079: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 525d220: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • e00c9bb: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • b174d5e: 8317601: Windows build on WSL broken after JDK-8317340
  • 54fbd4b: 8308479: [s390x] Implement alternative fast-locking scheme
  • 5cb041e: 8317340: Windows builds are not reproducible if MS VS compiler install path differs
  • 32987b7: 8317510: Change Windows debug symbol files naming to avoid losing info when an executable and a library share the same name
  • 37888d2: 8314191: C2 compilation fails with "bad AD file"
  • 9008889: 8316679: C2 SuperWord: wrong result, load should not be moved before store if not comparable
  • 0e2a520: 8318951: Additional negative value check in JPEG decoding
  • ... and 206 more: https://git.openjdk.org/jdk21u/compare/72980bd8981cc61f3edb73ef98a130f5b47e30be...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

⚠️ @jaikiran This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated approval labels Sep 7, 2023
@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

@jaikiran This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@jaikiran
Copy link
Member Author

I did not realize that this backport was approved in JBS almost 2 months back (I see that the jdk21u-fix-yes label on the JBS issue). I'll go ahead and integrate this today.

@jaikiran
Copy link
Member Author

/integrate

@jaikiran
Copy link
Member Author

Can I please get a sponsor for this backport in JDK 21u repo?

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@jaikiran
Your change (at version 4d0f39e) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

dfuch commented Nov 14, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Nov 14, 2023

Going to push as commit bac4829.
Since your change was applied there have been 221 commits pushed to the master branch:

  • 3515f60: 8310596: Utilize existing method frame::interpreter_frame_monitor_size_in_bytes()
  • daf76eb: 8319339: Internal error on spurious markup in a hybrid snippet
  • be539fd: 8318961: increase javacserver connection timeout values and max retry attempts
  • ccc2fd0: 8319922: libCreationTimeHelper.so fails to link in JDK 21
  • 0049afb: 8319828: runtime/NMT/VirtualAllocCommitMerge.java may fail if mixing interpreted and compiled native invocations
  • c952079: 8317507: C2 compilation fails with "Exceeded _node_regs array"
  • 525d220: 8318736: com/sun/jdi/JdwpOnThrowTest.java failed with "transport error 202: bind failed: Address already in use"
  • e00c9bb: 8225377: type annotations are not visible to javac plugins across compilation boundaries
  • b174d5e: 8317601: Windows build on WSL broken after JDK-8317340
  • 54fbd4b: 8308479: [s390x] Implement alternative fast-locking scheme
  • ... and 211 more: https://git.openjdk.org/jdk21u/compare/72980bd8981cc61f3edb73ef98a130f5b47e30be...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 14, 2023
@openjdk openjdk bot closed this Nov 14, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Nov 14, 2023
@openjdk
Copy link

openjdk bot commented Nov 14, 2023

@dfuch @jaikiran Pushed as commit bac4829.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@jaikiran jaikiran deleted the backport-8312433 branch November 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants