Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges #135

Closed

Conversation

RealCLanger
Copy link
Contributor

@RealCLanger RealCLanger commented Sep 5, 2023

Hi all,

This pull request contains a backport of JDK-8314094, commit 69c9ec92 from the openjdk/jdk repository.

The commit being backported was authored by Christoph Langer on 5 Sep 2023 and was reviewed by Matthias Baesken and Arno Zeller.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314094 needs maintainer approval

Issue

  • JDK-8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/135/head:pull/135
$ git checkout pull/135

Update a local copy of the PR:
$ git checkout pull/135
$ git pull https://git.openjdk.org/jdk21u.git pull/135/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 135

View PR using the GUI difftool:
$ git pr show -t 135

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/135.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 5, 2023

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 69c9ec92d04a399946b2157690a1dc3fec517329 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges Sep 5, 2023
@openjdk
Copy link

openjdk bot commented Sep 5, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 5, 2023

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 8565c71: 8315863: [GHA] Update checkout action to use v4
  • 1927930: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows
  • 3973d5e: 8315549: CITime misreports code/total nmethod sizes
  • 9343d46: 8315612: RISC-V: intrinsic for unsignedMultiplyHigh
  • 8477ff8: 8315206: RISC-V: hwprobe query is_set return wrong value
  • aef25fc: 8315452: Erroneous AST missing modifiers for partial input
  • 6e54e82: 8314495: Update to use jtreg 7.3.1
  • b207ce7: 8315383: jlink SystemModulesPlugin incorrectly parses the options
  • f1e8b19: 8313167: Update to use jtreg 7.3
  • f07c8f2: 8315688: Update jdk21u fix version to 21.0.2

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 5, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 5, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 7, 2023

⚠️ @RealCLanger This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval ready Pull request is ready to be integrated and removed ready Pull request is ready to be integrated approval labels Sep 7, 2023
@RealCLanger
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 13, 2023

Going to push as commit f6426fa.
Since your change was applied there have been 18 commits pushed to the master branch:

  • 9b983f3: 8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs
  • 1dac78c: 8315735: VerifyError when switch statement used with synchronized block
  • 27f635f: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview)
  • acf28f4: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
  • 292ac0f: 8311938: Add default cups include location for configure on AIX
  • d99b62b: 8312466: /bin/nm usage in AIX makes needs -X64 flag
  • 2d8be5c: 8315214: Do not run sun/tools/jhsdb tests concurrently
  • 82bb82a: 8311585: Add JRadioButtonMenuItem to bug8031573.java
  • 8565c71: 8315863: [GHA] Update checkout action to use v4
  • 1927930: 8308593: Add KEEPALIVE Extended Socket Options Support for Windows
  • ... and 8 more: https://git.openjdk.org/jdk21u/compare/49bef915bc643e4ea5e2a76c6f5e296b68fbc2a0...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 13, 2023
@openjdk openjdk bot closed this Sep 13, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 13, 2023
@openjdk
Copy link

openjdk bot commented Sep 13, 2023

@RealCLanger Pushed as commit f6426fa.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant