Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8315612: RISC-V: intrinsic for unsignedMultiplyHigh #139

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Sep 6, 2023

Hi all,

This pull request contains a backport of commit 5d3fdc17 from the openjdk/jdk repository.

The commit being backported was authored by Vladimir Kempik on 6 Sep 2023 and was reviewed by Fei Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315612 needs maintainer approval

Issue

  • JDK-8315612: RISC-V: intrinsic for unsignedMultiplyHigh (Enhancement - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/139/head:pull/139
$ git checkout pull/139

Update a local copy of the PR:
$ git checkout pull/139
$ git pull https://git.openjdk.org/jdk21u.git pull/139/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 139

View PR using the GUI difftool:
$ git pr show -t 139

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/139.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 6, 2023

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 5d3fdc1750645455d64a341e1437f779ba3fd20c 8315612: RISC-V: intrinsic for unsignedMultiplyHigh Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 6, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

⚠️ @VladimirKempik This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 6, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 6, 2023

Webrevs

@VladimirKempik
Copy link
Author

/approval request I would like to backport this to jdk21u, risc-v only change to C2, risc is low

@openjdk
Copy link

openjdk bot commented Sep 6, 2023

@VladimirKempik The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 6, 2023
@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315612: RISC-V: intrinsic for unsignedMultiplyHigh

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 8477ff8: 8315206: RISC-V: hwprobe query is_set return wrong value

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 8, 2023
@VladimirKempik
Copy link
Author

tier1 is clean
/integrate

@openjdk
Copy link

openjdk bot commented Sep 8, 2023

Going to push as commit 9343d46.
Since your change was applied there has been 1 commit pushed to the master branch:

  • 8477ff8: 8315206: RISC-V: hwprobe query is_set return wrong value

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 8, 2023
@openjdk openjdk bot closed this Sep 8, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 8, 2023
@openjdk
Copy link

openjdk bot commented Sep 8, 2023

@VladimirKempik Pushed as commit 9343d46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant