8308452: Extend internal Architecture enum with byte order and address size

[shipilev]

A batch for two clean backports that provide the grounds for other clean backports fixing the same files.

Additional testing:

• GHA

---

Progress

• JDK-8310982 needs maintainer approval
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• JDK-8308452 needs maintainer approval

Issues

• JDK-8308452: Extend internal Architecture enum with byte order and address size (Enhancement - P4 - Approved)
• JDK-8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM() (Bug - P2 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/151/head:pull/151
$ git checkout pull/151

Update a local copy of the PR:
$ git checkout pull/151
$ git pull https://git.openjdk.org/jdk21u.git pull/151/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 151

View PR using the GUI difftool:
$ git pr show -t 151

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/151.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[shipilev]

/issue add 8310982

[openjdk]

@shipilev
Adding additional issue to issue list: 8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM().

[shipilev]

Both backports are clean. They just need to go in together not to regress the test.

/clean

[openjdk]

@shipilev This backport pull request is now marked as clean

[openjdk]

⚠️ @shipilev This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (e2fc84cd)

[shipilev]

/approval 8310982
/approval 8308452

[openjdk]

@shipilev usage: /approval [<id>] (request|cancel) [<text>]

[openjdk]

@shipilev usage: /approval [<id>] (request|cancel) [<text>]

[shipilev]

/approval 8310982 request
/approval 8308452 request

[openjdk]

@shipilev The approval request has been created successfully.

[openjdk]

@shipilev The approval request has been created successfully.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308452: Extend internal Architecture enum with byte order and address size
8310982: jdk/internal/util/ArchTest.java fails after JDK-8308452 failed with Method isARM()

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

• f6426fa: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges
• 9b983f3: 8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs
• 1dac78c: 8315735: VerifyError when switch statement used with synchronized block
• 27f635f: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview)
• acf28f4: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
• 292ac0f: 8311938: Add default cups include location for configure on AIX
• d99b62b: 8312466: /bin/nm usage in AIX makes needs -X64 flag
• 2d8be5c: 8315214: Do not run sun/tools/jhsdb tests concurrently
• 82bb82a: 8311585: Add JRadioButtonMenuItem to bug8031573.java
• 8565c71: 8315863: [GHA] Update checkout action to use v4
• ... and 2 more: https://git.openjdk.org/jdk21u/compare/9343d4666a39eafc4972e33056b9eb20d2ebc729...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[shipilev]

Push approval granted.

/integrate

[openjdk]

Going to push as commit 88633d9.
Since your change was applied there have been 15 commits pushed to the master branch:

• 0294541: 8315751: RandomTestBsi1999 fails often with timeouts on Linux ppc64le
• 3eaecb0: 8313873: java/nio/channels/DatagramChannel/SendReceiveMaxSize.java fails on AIX due to small default RCVBUF size and different IPv6 Header interpretation
• efd090a: 8313792: Verify 4th party information in src/jdk.internal.le/share/legal/jline.md
• f6426fa: 8314094: java/lang/ProcessHandle/InfoTest.java fails on Windows when run as user with Administrator privileges
• 9b983f3: 8314935: Shenandoah: Unable to throw OOME on back-to-back Full GCs
• 1dac78c: 8315735: VerifyError when switch statement used with synchronized block
• 27f635f: 8311630: [s390] Implementation of Foreign Function & Memory API (Preview)
• acf28f4: 8311631: When multiple users run tools/jpackage/share/LicenseTest.java, Permission denied for writing /var/tmp/*.files
• 292ac0f: 8311938: Add default cups include location for configure on AIX
• d99b62b: 8312466: /bin/nm usage in AIX makes needs -X64 flag
• ... and 5 more: https://git.openjdk.org/jdk21u/compare/9343d4666a39eafc4972e33056b9eb20d2ebc729...master

Your commit was automatically rebased without conflicts.

[openjdk]

@shipilev Pushed as commit 88633d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.