Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX #160

Closed

Conversation

MBaesken
Copy link
Member

@MBaesken MBaesken commented Sep 14, 2023


Progress

  • JDK-8316123 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX (Sub-task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/160/head:pull/160
$ git checkout pull/160

Update a local copy of the PR:
$ git checkout pull/160
$ git pull https://git.openjdk.org/jdk21u.git pull/160/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 160

View PR using the GUI difftool:
$ git pr show -t 160

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/160.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 14, 2023

👋 Welcome back mbaesken! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 36552e7193a094936d5ed51be602b9c840d9b844 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX Sep 14, 2023
@openjdk
Copy link

openjdk bot commented Sep 14, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 14, 2023

⚠️ @MBaesken This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added rfr Pull request is ready for review approval labels Sep 14, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 14, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@MBaesken This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • b8f0f91: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads
  • 84cde0f: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • dfc32a0: 8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive
  • 918ce3e: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status
  • 5524b5e: 8316113: Infinite permission checking loop in java/net/spi/InetAddressResolverProvider/RuntimePermissionTest

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 18, 2023
@MBaesken
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

Going to push as commit acd23ac.
Since your change was applied there have been 11 commits pushed to the master branch:

  • 46f210c: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • f885c25: 8316087: Test SignedLoggerFinderTest.java is still failing
  • 2312578: 8315696: SignedLoggerFinderTest.java test failed
  • 51d738b: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
  • ad222a4: 8299614: Shenandoah: STW mark should keep nmethod/oops referenced from stack chunk alive
  • 1899ad0: 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV
  • b8f0f91: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads
  • 84cde0f: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • dfc32a0: 8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive
  • 918ce3e: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status
  • ... and 1 more: https://git.openjdk.org/jdk21u/compare/42e5cd806a2073f1855261a075ba4e00be6d001e...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2023
@openjdk openjdk bot closed this Sep 20, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@MBaesken Pushed as commit acd23ac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

1 participant