8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly

[biboudis]

---

Progress

• Change must not contain extraneous whitespace
• JDK-8314226 needs maintainer approval
• Commit message must refer to an issue

Issue

• JDK-8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/161/head:pull/161
$ git checkout pull/161

Update a local copy of the PR:
$ git checkout pull/161
$ git pull https://git.openjdk.org/jdk21u.git pull/161/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 161

View PR using the GUI difftool:
$ git pr show -t 161

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/161.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

⚠️ @biboudis This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

[mlbridge]

Webrevs

• 00: Full (ef9275bb)

[biboudis]

/approval JDK-8314226 request Involving guards and unnamed pattern variables in series of colon-style fallthrough switch cases, may not prove common in JDK21. However since this pattern explores a style of type structure analysis, it would be ideal to not have this style blocked.

[openjdk]

@biboudis The approval request has been created successfully.

[openjdk]

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

• cea4062: 8316031: SSLFlowDelegate should not log from synchronized block
• c0adad2: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
• c86bad5: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
• b9f54bd: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
• f33c9a3: 8313244: NM flags handling in configure process
• b8c5a9a: 8315579: SPARC64 builds are broken after JDK-8304913
• 2155ada: 8313206: PKCS11 tests silently skip execution
• 2f3e151: 8311813: C1: Uninitialized PhiResolver::_loop field
• fc11f38: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
• acd23ac: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
• ... and 10 more: https://git.openjdk.org/jdk21u/compare/5524b5e2e87a750ccc6f174da41784799969c0cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[biboudis]

/integrate

[openjdk]

@biboudis
Your change (at version ef9275b) is now ready to be sponsored by a Committer.

[lahodaj]

/sponsor

[openjdk]

Going to push as commit 742ff74.
Since your change was applied there have been 20 commits pushed to the master branch:

• cea4062: 8316031: SSLFlowDelegate should not log from synchronized block
• c0adad2: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
• c86bad5: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
• b9f54bd: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
• f33c9a3: 8313244: NM flags handling in configure process
• b8c5a9a: 8315579: SPARC64 builds are broken after JDK-8304913
• 2155ada: 8313206: PKCS11 tests silently skip execution
• 2f3e151: 8311813: C1: Uninitialized PhiResolver::_loop field
• fc11f38: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
• acd23ac: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
• ... and 10 more: https://git.openjdk.org/jdk21u/compare/5524b5e2e87a750ccc6f174da41784799969c0cf...master

Your commit was automatically rebased without conflicts.

[openjdk]

@lahodaj @biboudis Pushed as commit 742ff74.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.