Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8314632: Intra-case dominance check fails in the presence of a guard #162

Closed

Conversation

biboudis
Copy link
Member

@biboudis biboudis commented Sep 15, 2023


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8314632 needs maintainer approval

Issue

  • JDK-8314632: Intra-case dominance check fails in the presence of a guard (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/162/head:pull/162
$ git checkout pull/162

Update a local copy of the PR:
$ git checkout pull/162
$ git pull https://git.openjdk.org/jdk21u.git pull/162/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 162

View PR using the GUI difftool:
$ git pr show -t 162

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/162.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back abimpoudis! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 81f8c57e4a14e0186f608cbe5a899322df80fd30 8314632: Intra-case dominance check fails in the presence of a guard Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

⚠️ @biboudis This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 15, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

@biboudis
Copy link
Member Author

/approval JDK-8314632 The presence of a guard should not affect the intra-case dominance check. While this is a bug, it also has the potential to confuse users who want to understand the capability that a case with multiple patterns has to offer. It would be best to backport this bugfix to avoid this issue.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@biboudis usage: /approval [<id>] (request|cancel) [<text>]

@biboudis
Copy link
Member Author

/approval JDK-8314632 request The presence of a guard should not affect the intra-case dominance check. While this is a bug, it also has the potential to confuse users who want to understand the capability that a case with multiple patterns has to offer. It would be best to backport this bugfix to avoid this issue.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@biboudis The approval request has been created successfully.

@openjdk openjdk bot added the approval label Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@biboudis This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8314632: Intra-case dominance check fails in the presence of a guard

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 20 new commits pushed to the master branch:

  • cea4062: 8316031: SSLFlowDelegate should not log from synchronized block
  • c0adad2: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • c86bad5: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • b9f54bd: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • f33c9a3: 8313244: NM flags handling in configure process
  • b8c5a9a: 8315579: SPARC64 builds are broken after JDK-8304913
  • 2155ada: 8313206: PKCS11 tests silently skip execution
  • 2f3e151: 8311813: C1: Uninitialized PhiResolver::_loop field
  • fc11f38: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
  • acd23ac: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
  • ... and 10 more: https://git.openjdk.org/jdk21u/compare/5524b5e2e87a750ccc6f174da41784799969c0cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 21, 2023
@biboudis
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@biboudis
Your change (at version 9fa5397) is now ready to be sponsored by a Committer.

@lahodaj
Copy link
Contributor

lahodaj commented Sep 22, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit fa64237.
Since your change was applied there have been 21 commits pushed to the master branch:

  • 742ff74: 8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly
  • cea4062: 8316031: SSLFlowDelegate should not log from synchronized block
  • c0adad2: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • c86bad5: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • b9f54bd: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • f33c9a3: 8313244: NM flags handling in configure process
  • b8c5a9a: 8315579: SPARC64 builds are broken after JDK-8304913
  • 2155ada: 8313206: PKCS11 tests silently skip execution
  • 2f3e151: 8311813: C1: Uninitialized PhiResolver::_loop field
  • fc11f38: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
  • ... and 11 more: https://git.openjdk.org/jdk21u/compare/5524b5e2e87a750ccc6f174da41784799969c0cf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@lahodaj @biboudis Pushed as commit fa64237.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants