Skip to content

8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

zifeihan
Copy link
Member

@zifeihan zifeihan commented Sep 15, 2023

Hi, This issue also exists in the JDK21U, so i would like to backport this to jdk21u make vector api work correctly when qemu enabled the parameter rvv_ta_all_1s=true.
test/jdk/jdk/incubator/vector passed with fastdebug and use build using qemu with rvv_ma_all_1s=true,rvv_ta_all_1s=true and UseRVV.

Testing:

qemu with rvv_ma_all_1s=true,rvv_ta_all_1s=true and UseRVV:

  • Tier1 tests (release)
  • Tier2 tests (release)
  • Tier3 tests (release)
  • test/jdk/jdk/incubator/vector (fastdebug)

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8315931 needs maintainer approval

Issue

  • JDK-8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/165/head:pull/165
$ git checkout pull/165

Update a local copy of the PR:
$ git checkout pull/165
$ git pull https://git.openjdk.org/jdk21u.git pull/165/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 165

View PR using the GUI difftool:
$ git pr show -t 165

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/165.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back gcao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 4070829ae589678578a93b2886e02e04cf0a1b01 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

⚠️ @zifeihan This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Sep 15, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

@zifeihan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • b8f0f91: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads
  • 84cde0f: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • dfc32a0: 8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive
  • 918ce3e: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 18, 2023
@zifeihan
Copy link
Member Author

/integrate

@RealFYang
Copy link
Member

/sponsor

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@zifeihan
Your change (at version c44e962) is now ready to be sponsored by a Committer.

@openjdk
Copy link

openjdk bot commented Sep 19, 2023

Going to push as commit 1899ad0.
Since your change was applied there have been 4 commits pushed to the master branch:

  • b8f0f91: 8315702: jcmd Thread.dump_to_file slow with millions of virtual threads
  • 84cde0f: 8314759: VirtualThread.parkNanos timeout adjustment when pinned should be replaced
  • dfc32a0: 8312166: (dc) DatagramChannel's socket adaptor does not release carrier thread when blocking in receive
  • 918ce3e: 8309545: Thread.interrupted from virtual thread needlessly resets interrupt status

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 19, 2023
@openjdk openjdk bot closed this Sep 19, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Sep 19, 2023
@openjdk
Copy link

openjdk bot commented Sep 19, 2023

@RealFYang @zifeihan Pushed as commit 1899ad0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants