-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8301341: LinkedTransferQueue does not respect timeout for poll() #168
8301341: LinkedTransferQueue does not respect timeout for poll() #168
Conversation
👋 Welcome back robm! A progress list of the required criteria for merging this PR into |
This backport pull request has now been updated with issues from the original commit. |
|
@robm-openjdk This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 139 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
/integrate |
Webrevs
|
@robm-openjdk Your integration request cannot be fulfilled at this time, as your changes failed the final jcheck:
|
* traversal chains and out-of-order updates, while smaller values | ||
* increase CAS contention and overhead. Using the smallest | ||
* non-zero value of one is both simple and empirically a good | ||
* choice in most applicatkions. The slack value is hard-wired: a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
typo: applicatkions
* 5. Park/unpark signalling otherwise relies on a Dekker-like | ||
* scheme in which the caller advertises the need to unpark by | ||
* setting its waiter field, followed by a full fence and recheck | ||
* before actually parking. An explicit fence in used here rather |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in used -> is used
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OOPS - I shouldn't have looked at this - didn't reallize it was a backport
@robm-openjdk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
I don't see any problem backporting this. /cc @AlanBateman |
/integrate |
Going to push as commit bbc5ad7.
Your commit was automatically rebased without conflicts. |
@robm-openjdk Pushed as commit bbc5ad7. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backport
Progress
Issues
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/168/head:pull/168
$ git checkout pull/168
Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.org/jdk21u.git pull/168/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 168
View PR using the GUI difftool:
$ git pr show -t 168
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/168.diff
Webrev
Link to Webrev Comment