Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8301341: LinkedTransferQueue does not respect timeout for poll() #168

Closed

Conversation

robm-openjdk
Copy link
Member

@robm-openjdk robm-openjdk commented Sep 15, 2023

Backport

  • 830134
  • 8300663
  • 8267502

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • JDK-8301341 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8300663 needs maintainer approval
  • JDK-8267502 needs maintainer approval

Issues

  • JDK-8301341: LinkedTransferQueue does not respect timeout for poll() (Bug - P4 - Approved)
  • JDK-8300663: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=true i=0 j=1" (Bug - P3 - Approved)
  • JDK-8267502: JDK-8246677 caused 16x performance regression in SynchronousQueue (Bug - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/168/head:pull/168
$ git checkout pull/168

Update a local copy of the PR:
$ git checkout pull/168
$ git pull https://git.openjdk.org/jdk21u.git pull/168/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 168

View PR using the GUI difftool:
$ git pr show -t 168

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/168.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 15, 2023

👋 Welcome back robm! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 8d1ab57065c7ebcc650b5fb4ae098f8b0a35f112 8301341: LinkedTransferQueue does not respect timeout for poll() Sep 15, 2023
@openjdk
Copy link

openjdk bot commented Sep 15, 2023

This backport pull request has now been updated with issues from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

⚠️ @robm-openjdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@robm-openjdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8301341: LinkedTransferQueue does not respect timeout for poll()
8300663: java/util/concurrent/SynchronousQueue/Fairness.java failed with "Error: fair=true i=0 j=1"
8267502: JDK-8246677 caused 16x performance regression in SynchronousQueue

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 139 new commits pushed to the master branch:

  • 69adcc6: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • a811300: 8314330: java/foreign tests should respect vm flags when start new processes
  • 067cd17: 8295555: Primitive wrapper caches could be @Stable
  • 9405b0c: 8318528: Rename TestUnstructuredLocking test
  • 502d30b: 8318540: make test cannot run .jasm tests directly
  • 1f75ab2: 8267509: Improve IllegalAccessException message to include the cause of the exception
  • f4ed66e: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 305e9ec: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818
  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows
  • ... and 129 more: https://git.openjdk.org/jdk21u/compare/5524b5e2e87a750ccc6f174da41784799969c0cf...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 15, 2023
@robm-openjdk
Copy link
Member Author

/integrate

@mlbridge
Copy link

mlbridge bot commented Sep 15, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 15, 2023

@robm-openjdk Your integration request cannot be fulfilled at this time, as your changes failed the final jcheck:

  • 8300663 is used in problem lists: [test/jdk/ProblemList.txt]

* traversal chains and out-of-order updates, while smaller values
* increase CAS contention and overhead. Using the smallest
* non-zero value of one is both simple and empirically a good
* choice in most applicatkions. The slack value is hard-wired: a
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo: applicatkions

* 5. Park/unpark signalling otherwise relies on a Dekker-like
* scheme in which the caller advertises the need to unpark by
* setting its waiter field, followed by a full fence and recheck
* before actually parking. An explicit fence in used here rather
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in used -> is used

Copy link
Member

@Martin-Buchholz Martin-Buchholz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OOPS - I shouldn't have looked at this - didn't reallize it was a backport

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 30, 2023

@robm-openjdk This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@openjdk openjdk bot removed clean ready Pull request is ready to be integrated labels Oct 31, 2023
@viktorklang-ora
Copy link

I don't see any problem backporting this. /cc @AlanBateman

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Nov 1, 2023
@robm-openjdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Nov 1, 2023

Going to push as commit bbc5ad7.
Since your change was applied there have been 139 commits pushed to the master branch:

  • 69adcc6: 8312126: NullPointerException in CertStore.getCRLs after 8297955
  • a811300: 8314330: java/foreign tests should respect vm flags when start new processes
  • 067cd17: 8295555: Primitive wrapper caches could be @Stable
  • 9405b0c: 8318528: Rename TestUnstructuredLocking test
  • 502d30b: 8318540: make test cannot run .jasm tests directly
  • 1f75ab2: 8267509: Improve IllegalAccessException message to include the cause of the exception
  • f4ed66e: 8318705: [macos] ProblemList java/rmi/registry/multipleRegistries/MultipleRegistries.java
  • 305e9ec: 8315971: ProblemList containers/docker/TestMemoryAwareness.java on linux-all
  • c5a6a74: 8317692: jcmd GC.heap_dump performance regression after JDK-8292818
  • 5ebc02b: 8317751: ProblemList ConsumeForModalDialogTest.java, MenuItemActivatedTest.java & MouseModifiersUnitTest_Standard.java for windows
  • ... and 129 more: https://git.openjdk.org/jdk21u/compare/5524b5e2e87a750ccc6f174da41784799969c0cf...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Nov 1, 2023
@openjdk openjdk bot closed this Nov 1, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Nov 1, 2023
@openjdk
Copy link

openjdk bot commented Nov 1, 2023

@robm-openjdk Pushed as commit bbc5ad7.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

4 participants