Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316031: SSLFlowDelegate should not log from synchronized block #171

Closed
wants to merge 1 commit into from

Conversation

dfuch
Copy link
Member

@dfuch dfuch commented Sep 18, 2023

Hi all,

This pull request contains a backport of commit [dc5ca1d3](https://urldefense.com/v3/__https://github.com/openjdk/jdk/commit/dc5ca1d3798727fd29a6a40e9f7777cb7f85c004__;!!ACWV5N9M2RV99hQ!LQ0pZvkfxVjWFGxT56H4vhWDMpHSU7sXkopR0eQ02tdWFkP3QUgJ_HaXrn-rnfoyCxfTiQ9ipwQtjfgDsmkImBvO9tQ$) from the [openjdk/jdk](https://git.openjdk.org/jdk) repository.

The commit being backported was authored by Daniel Fuchs on 15 Sep 2023 and was reviewed by Daniel Jeliński.

Thanks!

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316031 needs maintainer approval

Issue

  • JDK-8316031: SSLFlowDelegate should not log from synchronized block (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/171/head:pull/171
$ git checkout pull/171

Update a local copy of the PR:
$ git checkout pull/171
$ git pull https://git.openjdk.org/jdk21u.git pull/171/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 171

View PR using the GUI difftool:
$ git pr show -t 171

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/171.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 18, 2023

👋 Welcome back dfuchs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport dc5ca1d3798727fd29a6a40e9f7777cb7f85c004 8316031: SSLFlowDelegate should not log from synchronized block Sep 18, 2023
@openjdk
Copy link

openjdk bot commented Sep 18, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 18, 2023

⚠️ @dfuch This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added approval rfr Pull request is ready for review labels Sep 18, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 18, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@dfuch This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316031: SSLFlowDelegate should not log from synchronized block

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • 2f3e151: 8311813: C1: Uninitialized PhiResolver::_loop field
  • fc11f38: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
  • acd23ac: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
  • 46f210c: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • f885c25: 8316087: Test SignedLoggerFinderTest.java is still failing
  • 2312578: 8315696: SignedLoggerFinderTest.java test failed
  • 51d738b: 8314263: Signed jars triggering Logger finder recursion and StackOverflowError
  • ad222a4: 8299614: Shenandoah: STW mark should keep nmethod/oops referenced from stack chunk alive
  • 1899ad0: 8315931: RISC-V: xxxMaxVectorTestsSmokeTest fails when using RVV

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 21, 2023
@dfuch
Copy link
Member Author

dfuch commented Sep 21, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 21, 2023

Going to push as commit cea4062.
Since your change was applied there have been 15 commits pushed to the master branch:

  • c0adad2: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • c86bad5: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • b9f54bd: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • f33c9a3: 8313244: NM flags handling in configure process
  • b8c5a9a: 8315579: SPARC64 builds are broken after JDK-8304913
  • 2155ada: 8313206: PKCS11 tests silently skip execution
  • 2f3e151: 8311813: C1: Uninitialized PhiResolver::_loop field
  • fc11f38: 8315644: increase timeout of sun/security/tools/jarsigner/Warning.java
  • acd23ac: 8316123: ProblemList serviceability/dcmd/gc/RunFinalizationTest.java on AIX
  • 46f210c: 8311514: Incorrect regex in TestMetaSpaceLog.java
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/b8f0f91e4fefba5f6cfadabdf024fce3235a2d2d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 21, 2023
@openjdk openjdk bot closed this Sep 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 21, 2023
@openjdk
Copy link

openjdk bot commented Sep 21, 2023

@dfuch Pushed as commit cea4062.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant