Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308592: Framework for CA interoperability testing #182

Closed

Conversation

rhalade
Copy link
Member

@rhalade rhalade commented Sep 20, 2023

Clean backport to JDK 21u.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8308592 needs maintainer approval

Issue

  • JDK-8308592: Framework for CA interoperability testing (Enhancement - P3 - Approved)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/182/head:pull/182
$ git checkout pull/182

Update a local copy of the PR:
$ git checkout pull/182
$ git pull https://git.openjdk.org/jdk21u.git pull/182/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 182

View PR using the GUI difftool:
$ git pr show -t 182

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/182.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 20, 2023

👋 Welcome back rhalade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport da57d2a1eb409ddc64117865c7d24ed518421cab 8308592: Framework for CA interoperability testing Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

⚠️ @rhalade This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 20, 2023
@rhalade
Copy link
Member Author

rhalade commented Sep 20, 2023

/label security

@openjdk
Copy link

openjdk bot commented Sep 20, 2023

@rhalade
The label security is not a valid label.
These labels are valid:

@mlbridge
Copy link

mlbridge bot commented Sep 20, 2023

Webrevs

@openjdk openjdk bot added the approval label Sep 20, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@rhalade This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308592: Framework for CA interoperability testing

Reviewed-by: mullan

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • fa64237: 8314632: Intra-case dominance check fails in the presence of a guard
  • 742ff74: 8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly
  • cea4062: 8316031: SSLFlowDelegate should not log from synchronized block
  • c0adad2: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • c86bad5: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • b9f54bd: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • f33c9a3: 8313244: NM flags handling in configure process
  • b8c5a9a: 8315579: SPARC64 builds are broken after JDK-8304913
  • 2155ada: 8313206: PKCS11 tests silently skip execution

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 22, 2023
@rhalade
Copy link
Member Author

rhalade commented Sep 22, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

Going to push as commit 3b690f1.
Since your change was applied there have been 10 commits pushed to the master branch:

  • e2bfc22: 8315578: PPC builds are broken after JDK-8304913
  • fa64237: 8314632: Intra-case dominance check fails in the presence of a guard
  • 742ff74: 8314226: Series of colon-style fallthrough switch cases with guards compiled incorrectly
  • cea4062: 8316031: SSLFlowDelegate should not log from synchronized block
  • c0adad2: 8316400: Exclude jdk/jfr/event/runtime/TestResidentSetSizeEvent.java on AIX
  • c86bad5: 8316387: Exclude more failing multicast tests on AIX after JDK-8315651
  • b9f54bd: 8315651: Stop hiding AIX specific multicast socket errors via NetworkConfiguration (aix)
  • f33c9a3: 8313244: NM flags handling in configure process
  • b8c5a9a: 8315579: SPARC64 builds are broken after JDK-8304913
  • 2155ada: 8313206: PKCS11 tests silently skip execution

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 22, 2023
@openjdk openjdk bot closed this Sep 22, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

@rhalade Pushed as commit 3b690f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants