8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere #19

TobiHartmann · 2023-07-27T12:01:05Z

Parsing of -XX:CompileOnly= hits a ShouldNotReachHere for , and arguments. The fix is to remove the assumption that className can only be null for method_sep because the parsing loop also exits on , and :

jdk21u/src/hotspot/share/compiler/compilerOracle.cpp

Lines 1032 to 1037 in 384a8b8

    
           for (i = 0; 
        
                i < 1024 && *line != '\0' && *line != method_sep && *line != ',' && !isspace(*line); 
        
                line++, i++) { 
        
             name[i] = *line; 
        
             if (name[i] == '.')  name[i] = '/';  // package prefix uses '/' 
        
           }

Instead, a missing class name is handled as "Any" class match in all the cases.

I'm fixing this in JDK 21u because the issue was fixed in in JDK 22 as a side effect of JDK-8027711. The VM now prints an error:

CompileOnly: An error occurred during parsing
Line: ','
Error: Could not create the Java Virtual Machine.
Error: A fatal exception has occurred. Program will exit.

Thanks,
Tobias

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere (Bug - P4)

Reviewers

Vladimir Kozlov (@vnkozlov - Reviewer) ⚠️ Review applies to 51e2ed8e
Tobias Holenstein (@tobiasholenstein - no project role)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/19/head:pull/19
$ git checkout pull/19

Update a local copy of the PR:
$ git checkout pull/19
$ git pull https://git.openjdk.org/jdk21u.git pull/19/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19

View PR using the GUI difftool:
$ git pr show -t 19

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/19.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2023-07-27T12:01:28Z

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

mlbridge · 2023-07-27T12:08:03Z

Webrevs

01: Full - Incremental (0bfc5ce1)
00: Full (51e2ed8e)

vnkozlov

Good.

openjdk · 2023-07-27T13:36:17Z

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere

Reviewed-by: kvn, tholenstein

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 18 new commits pushed to the master branch:

5c6cd06: Merge
731b2e9: 8313316: Disable runtime/ErrorHandling/MachCodeFramesInErrorFile.java on ppc64le
0439d58: 8300937: Update nroff pages in JDK 21 before RC
bb63b79: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86
f242c3b: 8313241: Temporarily disable "malformed control flow" assert to reduce noise
1c875fd: 8313250: Exclude java/foreign/TestByteBuffer.java on AIX
3e9344a: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
a10dbce: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms
f666e60: 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64
d65f1c8: 8312395: Improve assertions in growableArray
... and 8 more: https://git.openjdk.org/jdk21u/compare/e04b3061fc146203730929364e22f08930eb378d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

TobiHartmann · 2023-07-28T08:41:36Z

Thanks, Vladimir!

tobiasholenstein

Looks good to me

tobiasholenstein · 2023-08-02T06:30:44Z

src/hotspot/share/compiler/compilerOracle.cpp

-          c_match = MethodMatcher::Any;
-        }
-      }
+    if (className == NULL || className[0] == '\0') {


Suggested change

if (className == NULL || className[0] == '\0') {

if (className == nullptr || className[0] == '\0') {

I think it should be nullptr

Good catch! Fixed.

TobiHartmann · 2023-08-02T06:33:30Z

Thanks for the review, Toby.

TobiHartmann · 2023-08-02T06:35:34Z

/integrate

openjdk · 2023-08-02T06:36:56Z

Going to push as commit 6f76b65.
Since your change was applied there have been 18 commits pushed to the master branch:

5c6cd06: Merge
731b2e9: 8313316: Disable runtime/ErrorHandling/MachCodeFramesInErrorFile.java on ppc64le
0439d58: 8300937: Update nroff pages in JDK 21 before RC
bb63b79: 8313260: JDK21: ProblemList java/lang/ScopedValue/StressStackOverflow.java on linux-x86
f242c3b: 8313241: Temporarily disable "malformed control flow" assert to reduce noise
1c875fd: 8313250: Exclude java/foreign/TestByteBuffer.java on AIX
3e9344a: 8312293: SIGSEGV in jfr.internal.event.EventWriter.putUncheckedByte after JDK-8312086
a10dbce: 8313208: ProblemList java/util/concurrent/tck/JSR166TestCase.java on select platforms
f666e60: 8313193: ProblemList java/util/concurrent/SynchronousQueue/Fairness.java on X64
d65f1c8: 8312395: Improve assertions in growableArray
... and 8 more: https://git.openjdk.org/jdk21u/compare/e04b3061fc146203730929364e22f08930eb378d...master

Your commit was automatically rebased without conflicts.

openjdk · 2023-08-02T06:37:04Z

@TobiHartmann Pushed as commit 6f76b65.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere

51e2ed8

openjdk bot added the rfr Pull request is ready for review label Jul 27, 2023

vnkozlov approved these changes Jul 27, 2023

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 27, 2023

tobiasholenstein reviewed Aug 2, 2023

View reviewed changes

Change NULL to nullptr

0bfc5ce

tobiasholenstein approved these changes Aug 2, 2023

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Aug 2, 2023

openjdk bot closed this Aug 2, 2023

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere #19

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere #19

Uh oh!

TobiHartmann commented Jul 27, 2023 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jul 27, 2023

Uh oh!

mlbridge bot commented Jul 27, 2023 •

edited

Loading

Uh oh!

vnkozlov left a comment

Uh oh!

openjdk bot commented Jul 27, 2023 •

edited

Loading

Uh oh!

TobiHartmann commented Jul 28, 2023

Uh oh!

tobiasholenstein left a comment

Uh oh!

tobiasholenstein Aug 2, 2023

Uh oh!

tobiasholenstein Aug 2, 2023

Uh oh!

TobiHartmann Aug 2, 2023

Uh oh!

TobiHartmann commented Aug 2, 2023

Uh oh!

TobiHartmann commented Aug 2, 2023

Uh oh!

openjdk bot commented Aug 2, 2023

Uh oh!

openjdk bot commented Aug 2, 2023

Uh oh!

Uh oh!

	for (i = 0;
	i < 1024 && line != '\0' && line != method_sep && line != ',' && !isspace(line);
	line++, i++) {
	name[i] = *line;
	if (name[i] == '.') name[i] = '/'; // package prefix uses '/'
	}

	if (className == NULL \|\| className[0] == '\0') {
	if (className == nullptr \|\| className[0] == '\0') {

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere #19

8312573: Failure during CompileOnly parsing leads to ShouldNotReachHere #19

Uh oh!

Conversation

TobiHartmann commented Jul 27, 2023 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Jul 27, 2023

Uh oh!

mlbridge bot commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

vnkozlov left a comment

Choose a reason for hiding this comment

Uh oh!

openjdk bot commented Jul 27, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

TobiHartmann commented Jul 28, 2023

Uh oh!

tobiasholenstein left a comment

Choose a reason for hiding this comment

Uh oh!

tobiasholenstein Aug 2, 2023

Choose a reason for hiding this comment

Uh oh!

tobiasholenstein Aug 2, 2023

Choose a reason for hiding this comment

Uh oh!

TobiHartmann Aug 2, 2023

Choose a reason for hiding this comment

Uh oh!

TobiHartmann commented Aug 2, 2023

Uh oh!

TobiHartmann commented Aug 2, 2023

Uh oh!

openjdk bot commented Aug 2, 2023

Uh oh!

openjdk bot commented Aug 2, 2023

Uh oh!

Uh oh!

TobiHartmann commented Jul 27, 2023 •

edited by openjdk bot

Loading

mlbridge bot commented Jul 27, 2023 •

edited

Loading

openjdk bot commented Jul 27, 2023 •

edited

Loading