Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316206: Test StretchedFontTest.java fails for Baekmuk font #196

Closed

Conversation

aivanov-jdk
Copy link
Member

@aivanov-jdk aivanov-jdk commented Sep 22, 2023

Clean backport.

This pull request contains a backport of commit 00f585bd from the openjdk/jdk repository.

The commit being backported was authored by Alexey Ivanov on 22 Sep 2023 and was reviewed by Alexander Zvegintsev, Phil Race and Goetz Lindenmaier.


Progress

  • JDK-8316206 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8316206: Test StretchedFontTest.java fails for Baekmuk font (Bug - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/196/head:pull/196
$ git checkout pull/196

Update a local copy of the PR:
$ git checkout pull/196
$ git pull https://git.openjdk.org/jdk21u.git pull/196/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 196

View PR using the GUI difftool:
$ git pr show -t 196

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/196.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 22, 2023

👋 Welcome back aivanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 00f585bd22f527eca0107a9b4ed366f25754f0be 8316206: Test StretchedFontTest.java fails for Baekmuk font Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 22, 2023

This backport pull request has now been updated with issue and summary from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 22, 2023

⚠️ @aivanov-jdk This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 22, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 22, 2023

Webrevs

@openjdk openjdk bot added the approval label Sep 22, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@aivanov-jdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316206: Test StretchedFontTest.java fails for Baekmuk font

Ignore broken fonts, i.e. the fonts for which
GlyphVector(TEXT).getVisualBounds().isEmpty() returns true

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 10 new commits pushed to the master branch:

  • 768592a: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
  • 86a1a44: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns
  • c6ff3f7: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 3b58919: 8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children
  • 9983caa: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • 4eafc45: 8313322: RISC-V: implement MD5 intrinsic
  • 305be8f: 8314045: ArithmeticException in GaloisCounterMode
  • 487a726: 8316178: Better diagnostic header for CodeBlobs
  • 3b690f1: 8308592: Framework for CA interoperability testing
  • e2bfc22: 8315578: PPC builds are broken after JDK-8304913

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Sep 25, 2023
@aivanov-jdk
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

Going to push as commit e2f32f1.
Since your change was applied there have been 12 commits pushed to the master branch:

  • be274aa: 8313575: Refactor PKCS11Test tests
  • ccf8451: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.
  • 768592a: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"
  • 86a1a44: 8313252: Java_sun_awt_windows_ThemeReader_paintBackground release resources in early returns
  • c6ff3f7: 8313164: src/java.desktop/windows/native/libawt/windows/awt_Robot.cpp GetRGBPixels adjust releasing of resources
  • 3b58919: 8315213: java/lang/ProcessHandle/TreeTest.java test enhance output of children
  • 9983caa: 8294427: Check boxes and radio buttons have rendering issues on Windows in High DPI env
  • 4eafc45: 8313322: RISC-V: implement MD5 intrinsic
  • 305be8f: 8314045: ArithmeticException in GaloisCounterMode
  • 487a726: 8316178: Better diagnostic header for CodeBlobs
  • ... and 2 more: https://git.openjdk.org/jdk21u/compare/fa642371ad548761c7a74c713f4824761a40da38...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 25, 2023
@openjdk openjdk bot closed this Sep 25, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

@aivanov-jdk Pushed as commit e2f32f1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant