Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 #199

Closed
wants to merge 1 commit into from

Conversation

GoeLin
Copy link
Member

@GoeLin GoeLin commented Sep 25, 2023

I backport this for parity with 17.0.10-oracle.

The backport deferral was meant for 21, not 21u. After it being backported to 17.0.10-oracle,
the risk of bringing it to 21u should be acceptable as this will have much less exposure.

Test passes (including 8312440). Will run it through SAPs testing.

Will make dependent PR for JDK-8312440.


Progress

  • JDK-8308103 needs maintainer approval
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 (Bug - P3 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/199/head:pull/199
$ git checkout pull/199

Update a local copy of the PR:
$ git checkout pull/199
$ git pull https://git.openjdk.org/jdk21u.git pull/199/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 199

View PR using the GUI difftool:
$ git pr show -t 199

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/199.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2023

👋 Welcome back goetz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport c6ab9c2905203e1ec897b3404f9179ff975d0054 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17 Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

⚠️ @GoeLin This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2023

Webrevs

@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@GoeLin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 9 new commits pushed to the master branch:

  • b12961d: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
  • 8f05d86: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22
  • d3c89cd: 8315606: Open source few swing text/html tests
  • 3130e03: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • ea00fca: 8316468: os::write incorrectly handles partial write
  • e2f32f1: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • be274aa: 8313575: Refactor PKCS11Test tests
  • ccf8451: 8316199: Remove sun/tools/jstatd/TestJstatd* tests from problemlist for Windows.
  • 768592a: 8314476: TestJstatdPortAndServer.java failed with "java.rmi.NoSuchObjectException: no such object in table"

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 3, 2023
@GoeLin
Copy link
Member Author

GoeLin commented Oct 4, 2023

/integrate

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

Going to push as commit bbfbc7b.
Since your change was applied there have been 12 commits pushed to the master branch:

  • 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
  • 89103c6: 8317257: RISC-V: llvm build broken
  • b4bb944: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b12961d: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
  • 8f05d86: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22
  • d3c89cd: 8315606: Open source few swing text/html tests
  • 3130e03: 8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies
  • ea00fca: 8316468: os::write incorrectly handles partial write
  • e2f32f1: 8316206: Test StretchedFontTest.java fails for Baekmuk font
  • be274aa: 8313575: Refactor PKCS11Test tests
  • ... and 2 more: https://git.openjdk.org/jdk21u/compare/86a1a44a621bbd9b4c4d821cbc75d4a541e82aea...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2023
@openjdk openjdk bot closed this Oct 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@GoeLin Pushed as commit bbfbc7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
1 participant