Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads #2

Conversation

VladimirKempik
Copy link

@VladimirKempik VladimirKempik commented Jun 20, 2023

Clean backport to jdk21u

Significantly Improves performance of intrinsic in some cases for String.indexOf on platforms withotu hardware misaligned memory acccess support


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads (Enhancement - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/2/head:pull/2
$ git checkout pull/2

Update a local copy of the PR:
$ git checkout pull/2
$ git pull https://git.openjdk.org/jdk21u.git pull/2/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 2

View PR using the GUI difftool:
$ git pr show -t 2

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/2.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 20, 2023

👋 Welcome back vkempik! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 6b942893868fa1a64977288bdbdb1bbff8bd9d9c 8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads Jun 20, 2023
@openjdk
Copy link

openjdk bot commented Jun 20, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jun 20, 2023

@VladimirKempik This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8309502: RISC-V: String.indexOf intrinsic may produce misaligned memory loads

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 20, 2023
@mlbridge
Copy link

mlbridge bot commented Jun 20, 2023

Webrevs

@kevinrushforth
Copy link
Member

@VladimirKempik You might already know this: You can request approval to get this into jdk21u following the jdk-updates approval process documented here: https://openjdk.org/projects/jdk-updates/approval.html

@VladimirKempik
Copy link
Author

Yeah, @kevinrushforth , there were no existing "jdk21u-fix-request" label in JBS, so I had to create new one.

@VladimirKempik
Copy link
Author

/integrate

@openjdk
Copy link

openjdk bot commented Jun 21, 2023

Going to push as commit 79d44fd.
Since your change was applied there have been 14 commits pushed to the master branch:

  • d02c85b: Merge
  • fb6f5f1: 8309228: Clarify EXPERIMENTAL flags comment in hotspot/share/runtime/globals.hpp
  • 7ca0f14: 8309957: Rename JDK-8309595 test to conform
  • bfffd8b: 8309595: Allow javadoc to process unnamed classes
  • ede16cd: 8310314: Misplaced "unnamed classes are a preview feature and are disabled by default" error
  • 08965e6: 8310259: Pin msys2/setup-msys2 github action to a specific commit
  • e0d3706: 8304835: jdk/jfr/event/oldobject/TestArrayInformation.java fails with "Could not find event with class ... as (leak) object"
  • 14c5091: 8310015: ZGC: Unbounded asynchronous unmapping can lead to running out of address space
  • 36e3fe9: 8309928: JFR: View issues
  • 4d81b89: 8309960: ParallelGC young collections very slow in DelayInducer
  • ... and 4 more: https://git.openjdk.org/jdk21u/compare/40eb08d43f9af03052b3f173fbe433736147119f...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 21, 2023
@openjdk openjdk bot closed this Jun 21, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 21, 2023
@openjdk
Copy link

openjdk bot commented Jun 21, 2023

@VladimirKempik Pushed as commit 79d44fd.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

theaoqi referenced this pull request in loongson/jdk21u Jan 10, 2024
27335: [C2] Make FP register allocable
27449: Codebuffer shared stubs enhancement
27464: [C2] Fix conditionally allocatable S5 to get correct ALL_REG_mask.size()
20630: [C2] adjust register pressure closer to allocable size
22010: Refactor fast_lock/unlock assembler
23531: Support monitor count
27499: LA port of JDK-8285435: Show file and line in MacroAssembler::verify_oop for AArch64 and RISC-V platforms (Port from x86)
27338: [JVMCI] Implement JVMCI for LoongArch64
27492: unify offsets of framePoint whether javaFrame of nativeFrame
27576: Revert MacroAssembler::remove_frame
26091: C1: Enable optimizations for RISC-V and LoongArch
27183: [C2] Make T4 allocatable
26733: C2: Load float immediate by vldi
27611: build failed with --disable-precompiled-headers
26284: Rectification of JNI argument shuffling
27604: Add reg class no_CR_reg
27648: Recursive locking case is not triggered in fast_lock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
2 participants