-
Notifications
You must be signed in to change notification settings - Fork 173
8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies #202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8315770: serviceability/sa/TestJmapCoreMetaspace.java should run with -XX:-VerifyDependencies #202
Conversation
Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315683 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch has been cleanly applied. Below are the test results: * after_release: **54.64s user 7.50s system 231% cpu 26.806 total** * after_fastdebug: **247.97s user 12.78s system 407% cpu 1:03.99 total** * before_release: **52.23s user 8.39s system 232% cpu 26.070 total** * before_fastdebug: **504.20s user 9.34s system 211% cpu 4:03.01 total**
|
👋 Welcome back roy-soumadipta! A progress list of the required criteria for merging this PR into |
|
This backport pull request has now been updated with issue from the original commit. |
|
|
|
/approval request Backport 877731d2a20249ce4724a071ba2da1faa56daca4 to JDK21u |
|
@roy-soumadipta The approval request has been created successfully. |
|
@roy-soumadipta This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 24 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
/integrate |
|
@roy-soumadipta |
|
/sponsor |
|
Going to push as commit 3130e03.
Your commit was automatically rebased without conflicts. |
|
@shipilev @roy-soumadipta Pushed as commit 3130e03. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Backporting the fix for https://bugs.openjdk.org/browse/JDK-8315770 merged as part of openjdk/jdk#15631. https://github.com/openjdk/jdk/commit/877731d2a20249ce4724a071ba2da1faa56daca4.patch has been cleanly applied.
Below are the test results:
Progress
Issue
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/202/head:pull/202$ git checkout pull/202Update a local copy of the PR:
$ git checkout pull/202$ git pull https://git.openjdk.org/jdk21u.git pull/202/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 202View PR using the GUI difftool:
$ git pr show -t 202Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/202.diff
Webrev
Link to Webrev Comment