Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8316859: RISC-V: Disable detection of V through HWCAP #203

Closed

Conversation

luhenry
Copy link
Member

@luhenry luhenry commented Sep 25, 2023

Hi all,

This pull request contains a backport of commit 311c7461 from the openjdk/jdk repository.

The commit being backported was authored by Ludovic Henry on 25 Sep 2023 and was reviewed by Robbin Ehn and Fei Yang.

Thanks!


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • JDK-8316859 needs maintainer approval

Issue

  • JDK-8316859: RISC-V: Disable detection of V through HWCAP (Task - P4 - Approved)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk21u.git pull/203/head:pull/203
$ git checkout pull/203

Update a local copy of the PR:
$ git checkout pull/203
$ git pull https://git.openjdk.org/jdk21u.git pull/203/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 203

View PR using the GUI difftool:
$ git pr show -t 203

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk21u/pull/203.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 25, 2023

👋 Welcome back luhenry! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot changed the title Backport 311c7461c8c0f5f1524d409736e4cceca8de9000 8316859: RISC-V: Disable detection of V through HWCAP Sep 25, 2023
@openjdk
Copy link

openjdk bot commented Sep 25, 2023

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Sep 25, 2023

⚠️ @luhenry This change is now ready for you to apply for maintainer approval. This can be done directly in each associated issue or by using the /approval command.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 25, 2023
@mlbridge
Copy link

mlbridge bot commented Sep 25, 2023

Webrevs

@sxa
Copy link
Contributor

sxa commented Sep 25, 2023

As mentioned on the original PR I've applied this patch on top of jdk-21+35 and it successfully prevents the SIGILL in my LicheePi board :-)

@RealFYang
Copy link
Member

RealFYang commented Sep 26, 2023

@luhenry : I see this is clean backport. Then you need to flag jdk21u-fix-request to get push approval from the maintainer [1].

[1] https://openjdk.org/projects/jdk-updates/approval.html

@openjdk openjdk bot added the approval label Sep 26, 2023
@openjdk
Copy link

openjdk bot commented Oct 3, 2023

@luhenry This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8316859: RISC-V: Disable detection of V through HWCAP

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 15 new commits pushed to the master branch:

  • 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
  • bbfbc7b: 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17
  • 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
  • 89103c6: 8317257: RISC-V: llvm build broken
  • b4bb944: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b12961d: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
  • 8f05d86: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22
  • d3c89cd: 8315606: Open source few swing text/html tests
  • ... and 5 more: https://git.openjdk.org/jdk21u/compare/768592a52fb36e66da77e7642f2a3c3cb2849e2d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added ready Pull request is ready to be integrated and removed approval labels Oct 3, 2023
@luhenry
Copy link
Member Author

luhenry commented Oct 4, 2023

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@luhenry
Your change (at version 2f916dd) is now ready to be sponsored by a Committer.

@robehn
Copy link
Contributor

robehn commented Oct 4, 2023

/sponsor

@openjdk
Copy link

openjdk bot commented Oct 4, 2023

Going to push as commit 69af26c.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 9ffec67: 8316566: RISC-V: Zero extended narrow oop passed to Atomic::cmpxchg
  • 90d4ff6: 8312440: assert(cast != nullptr) failed: must have added a cast to pin the node
  • 610f164: 8301247: JPackage app-image exe launches multiple exe's in JDK 17+
  • 67d2836: 8315377: C2: assert(u->find_out_with(Op_AddP) == nullptr) failed: more than 2 chained AddP nodes?
  • bbfbc7b: 8308103: Massive (up to ~30x) increase in C2 compilation time since JDK 17
  • 48fa33a: 8301489: C1: ShortLoopOptimizer might lift instructions before their inputs
  • 89103c6: 8317257: RISC-V: llvm build broken
  • b4bb944: 8316743: RISC-V: Change UseVectorizedMismatchIntrinsic option result to warning
  • b12961d: 8316933: RISC-V: compiler/vectorapi/VectorCastShape128Test.java fails when using RVV
  • 8f05d86: 8316341: sun/security/pkcs11/PKCS11Test.java needs adjustment on Linux ppc64le Ubuntu 22
  • ... and 6 more: https://git.openjdk.org/jdk21u/compare/768592a52fb36e66da77e7642f2a3c3cb2849e2d...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Oct 4, 2023
@openjdk openjdk bot closed this Oct 4, 2023
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Oct 4, 2023
@openjdk
Copy link

openjdk bot commented Oct 4, 2023

@robehn @luhenry Pushed as commit 69af26c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated
4 participants